You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/04 03:08:24 UTC

[GitHub] [spark] karenfeng opened a new pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

karenfeng opened a new pull request #33627:
URL: https://github.com/apache/spark/pull/33627


   ### What changes were proposed in this pull request?
   
   Adds validation that the SQLSTATEs in the error class JSON are a subset of those provided in the README.
   
   ### Why are the changes needed?
   
   Validation of error class JSON
   
   ### Does this PR introduce _any_ user-facing change?
   
   No
   
   ### How was this patch tested?
   
   Unit test


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925510613


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48039/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925275139


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48020/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892341672


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46528/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892855065


   **[Test build #142044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142044/testReport)** for PR 33627 at commit [`8546448`](https://github.com/apache/spark/commit/8546448f16553a1f2bf7a1bda1112913f560eea4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892325957


   **[Test build #142016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142016/testReport)** for PR 33627 at commit [`cfe31df`](https://github.com/apache/spark/commit/cfe31df4fd1a399e5188a0662eb50a0f9e9c89d9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon closed pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #33627:
URL: https://github.com/apache/spark/pull/33627


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925553081


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143531/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925553081


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143531/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892328976


   **[Test build #142016 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142016/testReport)** for PR 33627 at commit [`cfe31df`](https://github.com/apache/spark/commit/cfe31df4fd1a399e5188a0662eb50a0f9e9c89d9).
    * This patch **fails to build**.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920288665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47820/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] karenfeng commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
karenfeng commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920214905


   Thanks for the review @HyukjinKwon! Ready for another pass.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892909298






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925286778


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48020/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892909298






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892340024


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142016/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925325173


   **[Test build #143511 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143511/testReport)** for PR 33627 at commit [`7f2f313`](https://github.com/apache/spark/commit/7f2f3138dddfa54dcd903f7e81cc105182fa4b8c).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892909298


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920357472


   **[Test build #143317 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143317/testReport)** for PR 33627 at commit [`db2dba1`](https://github.com/apache/spark/commit/db2dba127b06199219a980364be311ef55c045fa).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920364283


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143317/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-893108499


   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892855065






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892966413


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142044/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920240671


   **[Test build #143317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143317/testReport)** for PR 33627 at commit [`db2dba1`](https://github.com/apache/spark/commit/db2dba127b06199219a980364be311ef55c045fa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33627:
URL: https://github.com/apache/spark/pull/33627#discussion_r705827236



##########
File path: core/src/main/resources/error/README.md
##########
@@ -98,6 +98,7 @@ Spark only uses the standard-defined classes and subclasses, and does not use im
 
 The following SQLSTATEs are from ISO/IEC CD 9075-2.
 
+[//]: # (SQLSTATE table start)

Review comment:
       Should we maybe use HTML comments like:
   
   ```
   <!-- SQLSTATE table start -->
   ...
   <!-- SQLSTATE table stop -->
   ```
   
   ?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925493660


   **[Test build #143531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143531/testReport)** for PR 33627 at commit [`1877bc4`](https://github.com/apache/spark/commit/1877bc48de3087134edbed6d3e45f20d4be3ba7d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892325957


   **[Test build #142016 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142016/testReport)** for PR 33627 at commit [`cfe31df`](https://github.com/apache/spark/commit/cfe31df4fd1a399e5188a0662eb50a0f9e9c89d9).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925531953


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48039/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925531953


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48039/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] karenfeng commented on a change in pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
karenfeng commented on a change in pull request #33627:
URL: https://github.com/apache/spark/pull/33627#discussion_r709387628



##########
File path: core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
##########
@@ -73,7 +74,17 @@ class SparkThrowableSuite extends SparkFunSuite {
 
   test("SQLSTATE invariants") {
     val sqlStates = errorClassToInfoMap.values.toSeq.flatMap(_.sqlState)
-    checkCondition(sqlStates, s => s.length == 5)
+    val errorClassReadMe = Utils.getSparkClassLoader.getResource("error/README.md")
+    val errorClassReadMeContents = IOUtils.toString(errorClassReadMe.openStream())
+    val sqlStateTableRegex =
+      "(?s)\\[//]: # \\(SQLSTATE table start\\)(.+)\\[//]: # \\(SQLSTATE table end\\)".r
+    val sqlTable = sqlStateTableRegex.findFirstIn(errorClassReadMeContents).get
+    val sqlTableRows = sqlTable.split("\n").filter(_.startsWith("|")).drop(2)
+    val validSqlStates = sqlTableRows.map(_.slice(1, 6)).toSet
+    // Sanity check
+    assert(Set("07000", "42000", "HZ000").subsetOf(validSqlStates), validSqlStates)

Review comment:
       We validate the SQLSTATEs in the JSON below. This just checks that we extracted SQLSTATEs from the table.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on a change in pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on a change in pull request #33627:
URL: https://github.com/apache/spark/pull/33627#discussion_r705827380



##########
File path: core/src/test/scala/org/apache/spark/SparkThrowableSuite.scala
##########
@@ -73,7 +74,17 @@ class SparkThrowableSuite extends SparkFunSuite {
 
   test("SQLSTATE invariants") {
     val sqlStates = errorClassToInfoMap.values.toSeq.flatMap(_.sqlState)
-    checkCondition(sqlStates, s => s.length == 5)
+    val errorClassReadMe = Utils.getSparkClassLoader.getResource("error/README.md")
+    val errorClassReadMeContents = IOUtils.toString(errorClassReadMe.openStream())
+    val sqlStateTableRegex =
+      "(?s)\\[//]: # \\(SQLSTATE table start\\)(.+)\\[//]: # \\(SQLSTATE table end\\)".r
+    val sqlTable = sqlStateTableRegex.findFirstIn(errorClassReadMeContents).get
+    val sqlTableRows = sqlTable.split("\n").filter(_.startsWith("|")).drop(2)
+    val validSqlStates = sqlTableRows.map(_.slice(1, 6)).toSet
+    // Sanity check
+    assert(Set("07000", "42000", "HZ000").subsetOf(validSqlStates), validSqlStates)

Review comment:
       Sorry maybe I missed something. But is there an easy to upload all existing error codes in Spark, and validate it?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892885494


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892855065


   **[Test build #142044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142044/testReport)** for PR 33627 at commit [`8546448`](https://github.com/apache/spark/commit/8546448f16553a1f2bf7a1bda1112913f560eea4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892341664


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46528/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925224917


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48020/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892341672


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46528/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892855065


   **[Test build #142044 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142044/testReport)** for PR 33627 at commit [`8546448`](https://github.com/apache/spark/commit/8546448f16553a1f2bf7a1bda1112913f560eea4).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925531899


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48039/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925176526


   **[Test build #143511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143511/testReport)** for PR 33627 at commit [`7f2f313`](https://github.com/apache/spark/commit/7f2f3138dddfa54dcd903f7e81cc105182fa4b8c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925493660


   **[Test build #143531 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143531/testReport)** for PR 33627 at commit [`1877bc4`](https://github.com/apache/spark/commit/1877bc48de3087134edbed6d3e45f20d4be3ba7d).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925286778


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48020/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920364283


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143317/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920287678


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47820/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925549768


   **[Test build #143531 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143531/testReport)** for PR 33627 at commit [`1877bc4`](https://github.com/apache/spark/commit/1877bc48de3087134edbed6d3e45f20d4be3ba7d).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920278551


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/47820/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925176526


   **[Test build #143511 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143511/testReport)** for PR 33627 at commit [`7f2f313`](https://github.com/apache/spark/commit/7f2f3138dddfa54dcd903f7e81cc105182fa4b8c).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925327430


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143511/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892949407


   **[Test build #142044 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142044/testReport)** for PR 33627 at commit [`8546448`](https://github.com/apache/spark/commit/8546448f16553a1f2bf7a1bda1112913f560eea4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892909274


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892909298


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46556/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] Peng-Lei commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
Peng-Lei commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-893108499


   +1


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920288665


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/47820/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] SparkQA removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-920240671


   **[Test build #143317 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/143317/testReport)** for PR 33627 at commit [`db2dba1`](https://github.com/apache/spark/commit/db2dba127b06199219a980364be311ef55c045fa).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892966413


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142044/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-924841398


   @karenfeng sorry I missed this one. mind rebasing this? I will merge it in.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins removed a comment on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925327430


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/143511/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] HyukjinKwon commented on pull request #33627: [SPARK-36405][SQL][TESTS] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-925515533


   Merged to master.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] [spark] AmplabJenkins commented on pull request #33627: [SPARK-36405] Check that SQLSTATEs are valid

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33627:
URL: https://github.com/apache/spark/pull/33627#issuecomment-892340024


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142016/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org