You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/06/11 01:51:17 UTC
[GitHub] [mynewt-core] apache-mynewt-bot commented on pull request #2849: sensors/lsm6dsl: add tilt function
apache-mynewt-bot commented on PR #2849:
URL: https://github.com/apache/mynewt-core/pull/2849#issuecomment-1152832570
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### hw/drivers/sensors/lsm6dsl/include/lsm6dsl/lsm6dsl.h
<details>
```diff
@@ -120,10 +120,10 @@
struct lsm6dsl_tap_settings {
/* Axis enabled bitmask */
- uint8_t en_x: 1;
- uint8_t en_y: 1;
- uint8_t en_z: 1;
- uint8_t en_dtap: 1;
+ uint8_t en_x : 1;
+ uint8_t en_y : 1;
+ uint8_t en_z : 1;
+ uint8_t en_dtap : 1;
/* Threshold for tap recognition */
int8_t tap_ths;
```
</details>
#### hw/drivers/sensors/lsm6dsl/src/lsm6dsl.c
<details>
```diff
@@ -103,35 +103,35 @@
/* Define the stats section and records */
STATS_SECT_START(lsm6dsl_stat_section)
- STATS_SECT_ENTRY(write_errors)
- STATS_SECT_ENTRY(read_errors)
+STATS_SECT_ENTRY(write_errors)
+STATS_SECT_ENTRY(read_errors)
#if MYNEWT_VAL(LSM6DSL_NOTIF_STATS)
- STATS_SECT_ENTRY(single_tap_notify)
- STATS_SECT_ENTRY(double_tap_notify)
- STATS_SECT_ENTRY(free_fall_notify)
- STATS_SECT_ENTRY(rel_tilt_notify)
- STATS_SECT_ENTRY(abs_tilt_pos_notify)
- STATS_SECT_ENTRY(abs_tilt_neg_notify)
- STATS_SECT_ENTRY(sleep_notify)
- STATS_SECT_ENTRY(orientation_notify)
- STATS_SECT_ENTRY(wakeup_notify)
+STATS_SECT_ENTRY(single_tap_notify)
+STATS_SECT_ENTRY(double_tap_notify)
+STATS_SECT_ENTRY(free_fall_notify)
+STATS_SECT_ENTRY(rel_tilt_notify)
+STATS_SECT_ENTRY(abs_tilt_pos_notify)
+STATS_SECT_ENTRY(abs_tilt_neg_notify)
+STATS_SECT_ENTRY(sleep_notify)
+STATS_SECT_ENTRY(orientation_notify)
+STATS_SECT_ENTRY(wakeup_notify)
#endif /* LSM6DSL_NOTIF_STATS */
STATS_SECT_END
/* Define stat names for querying */
STATS_NAME_START(lsm6dsl_stat_section)
- STATS_NAME(lsm6dsl_stat_section, write_errors)
- STATS_NAME(lsm6dsl_stat_section, read_errors)
+STATS_NAME(lsm6dsl_stat_section, write_errors)
+STATS_NAME(lsm6dsl_stat_section, read_errors)
#if MYNEWT_VAL(LSM6DSL_NOTIF_STATS)
- STATS_NAME(lsm6dsl_stat_section, single_tap_notify)
- STATS_NAME(lsm6dsl_stat_section, double_tap_notify)
- STATS_NAME(lsm6dsl_stat_section, rel_tilt_notify)
- STATS_NAME(lsm6dsl_stat_section, abs_tilt_pos_notify)
- STATS_NAME(lsm6dsl_stat_section, abs_tilt_neg_notify)
- STATS_NAME(lsm6dsl_stat_section, free_fall_notify)
- STATS_NAME(lsm6dsl_stat_section, sleep_notify)
- STATS_NAME(lsm6dsl_stat_section, orientation_notify)
- STATS_NAME(lsm6dsl_stat_section, wakeup_notify)
+STATS_NAME(lsm6dsl_stat_section, single_tap_notify)
+STATS_NAME(lsm6dsl_stat_section, double_tap_notify)
+STATS_NAME(lsm6dsl_stat_section, rel_tilt_notify)
+STATS_NAME(lsm6dsl_stat_section, abs_tilt_pos_notify)
+STATS_NAME(lsm6dsl_stat_section, abs_tilt_neg_notify)
+STATS_NAME(lsm6dsl_stat_section, free_fall_notify)
+STATS_NAME(lsm6dsl_stat_section, sleep_notify)
+STATS_NAME(lsm6dsl_stat_section, orientation_notify)
+STATS_NAME(lsm6dsl_stat_section, wakeup_notify)
#endif /* LSM6DSL_NOTIFY_STATS */
STATS_NAME_END(lsm6dsl_stat_section)
@@ -1036,7 +1036,7 @@
int
lsm6dsl_set_tilt(struct lsm6dsl *lsm6dsl,
- const struct lsm6dsl_tilt_settings *cfg)
+ const struct lsm6dsl_tilt_settings *cfg)
{
int rc;
uint8_t en_mask;
@@ -1049,7 +1049,8 @@
return rc;
}
if (cfg->en_wrist_tilt) {
- rc = lsm6dsl_write_reg(lsm6dsl, LSM6DSL_FUNC_CFG_ACCESS_REG, LSM6DSL_FUNC_CFG_ACCESS_MASK | LSM6DSL_SHUB_REG_ACCESS_MASK);
+ rc = lsm6dsl_write_reg(lsm6dsl, LSM6DSL_FUNC_CFG_ACCESS_REG,
+ LSM6DSL_FUNC_CFG_ACCESS_MASK | LSM6DSL_SHUB_REG_ACCESS_MASK);
if (rc) {
return rc;
}
@@ -2221,35 +2224,35 @@
{
#if MYNEWT_VAL(LSM6DSL_NOTIF_STATS)
switch (event) {
- case SENSOR_EVENT_TYPE_SINGLE_TAP:
- STATS_INC(g_lsm6dsl_stats, single_tap_notify);
- break;
- case SENSOR_EVENT_TYPE_DOUBLE_TAP:
- STATS_INC(g_lsm6dsl_stats, double_tap_notify);
- break;
- case SENSOR_EVENT_TYPE_ORIENT_CHANGE:
- STATS_INC(g_lsm6dsl_stats, orientation_notify);
- break;
- case SENSOR_EVENT_TYPE_SLEEP:
- STATS_INC(g_lsm6dsl_stats, sleep_notify);
- break;
- case SENSOR_EVENT_TYPE_WAKEUP:
- STATS_INC(g_lsm6dsl_stats, wakeup_notify);
- break;
- case SENSOR_EVENT_TYPE_FREE_FALL:
- STATS_INC(g_lsm6dsl_stats, free_fall_notify);
- break;
- case SENSOR_EVENT_TYPE_TILT_CHANGE:
- STATS_INC(g_lsm6dsl_stats, rel_tilt_notify);
- break;
- case SENSOR_EVENT_TYPE_TILT_POS:
- STATS_INC(g_lsm6dsl_stats, abs_tilt_pos_notify);
- break;
- case SENSOR_EVENT_TYPE_TILT_NEG:
- STATS_INC(g_lsm6dsl_stats, abs_tilt_neg_notify);
- break;
- default:
- break;
+ case SENSOR_EVENT_TYPE_SINGLE_TAP:
+ STATS_INC(g_lsm6dsl_stats, single_tap_notify);
+ break;
+ case SENSOR_EVENT_TYPE_DOUBLE_TAP:
+ STATS_INC(g_lsm6dsl_stats, double_tap_notify);
+ break;
+ case SENSOR_EVENT_TYPE_ORIENT_CHANGE:
+ STATS_INC(g_lsm6dsl_stats, orientation_notify);
+ break;
+ case SENSOR_EVENT_TYPE_SLEEP:
+ STATS_INC(g_lsm6dsl_stats, sleep_notify);
+ break;
+ case SENSOR_EVENT_TYPE_WAKEUP:
+ STATS_INC(g_lsm6dsl_stats, wakeup_notify);
+ break;
+ case SENSOR_EVENT_TYPE_FREE_FALL:
+ STATS_INC(g_lsm6dsl_stats, free_fall_notify);
+ break;
+ case SENSOR_EVENT_TYPE_TILT_CHANGE:
+ STATS_INC(g_lsm6dsl_stats, rel_tilt_notify);
+ break;
+ case SENSOR_EVENT_TYPE_TILT_POS:
+ STATS_INC(g_lsm6dsl_stats, abs_tilt_pos_notify);
+ break;
+ case SENSOR_EVENT_TYPE_TILT_NEG:
+ STATS_INC(g_lsm6dsl_stats, abs_tilt_neg_notify);
+ break;
+ default:
+ break;
}
#endif /* LSM6DSL_NOTIF_STATS */
}
```
</details>
#### hw/drivers/sensors/lsm6dsl/src/lsm6dsl_shell.c
<details>
```diff
@@ -197,7 +198,7 @@
rc = lsm6dsl_read(g_lsm6dsl, reg_name_banka[i].addr, &value, 1);
if (rc) {
console_printf("dump failed %d\n", rc);
- } else if (all || value != 0){
+ } else if (all || value != 0) {
console_printf("%-22s(0x%02X) = 0x%02X\n",
reg_name_banka[i].regname, reg_name_banka[i].addr, value);
}
@@ -208,7 +209,8 @@
}
/* Bank B */
- rc = lsm6dsl_write_reg(g_lsm6dsl, LSM6DSL_FUNC_CFG_ACCESS_REG, LSM6DSL_FUNC_CFG_ACCESS_MASK | LSM6DSL_SHUB_REG_ACCESS_MASK);
+ rc = lsm6dsl_write_reg(g_lsm6dsl, LSM6DSL_FUNC_CFG_ACCESS_REG,
+ LSM6DSL_FUNC_CFG_ACCESS_MASK | LSM6DSL_SHUB_REG_ACCESS_MASK);
if (rc) {
return rc;
}
@@ -216,7 +218,7 @@
rc = lsm6dsl_read(g_lsm6dsl, reg_name_bankb[i].addr, &value, 1);
if (rc) {
console_printf("dump failed %d\n", rc);
- } else if (all || value != 0){
+ } else if (all || value != 0) {
console_printf("%-22s(0x%02X) = 0x%02X\n",
reg_name_bankb[i].regname, reg_name_bankb[i].addr, value);
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org