You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@samza.apache.org by Aleksandar Pejakovic <a....@levi9.com> on 2015/08/20 11:25:20 UTC

Review Request 37642: SAMZA-695 Update the StreamAppender doc

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37642/
-----------------------------------------------------------

Review request for samza.


Repository: samza


Description
-------

Added requested param to logging.md


Diffs
-----

  docs/learn/documentation/versioned/jobs/logging.md d1b372c 

Diff: https://reviews.apache.org/r/37642/diff/


Testing
-------


Thanks,

Aleksandar Pejakovic

Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc

Posted by Aleksandar Pejakovic <a....@levi9.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37642/
-----------------------------------------------------------

(Updated Aug. 21, 2015, 7:23 a.m.)


Review request for samza.


Changes
-------

Fixed patch


Repository: samza


Description (updated)
-------

Added requested param to logging.md - fixed


Diffs (updated)
-----

  docs/learn/documentation/versioned/jobs/logging.md d1b372c 

Diff: https://reviews.apache.org/r/37642/diff/


Testing
-------


Thanks,

Aleksandar Pejakovic

Re: Review Request 37642: SAMZA-695 Update the StreamAppender doc

Posted by Yan Fang <ya...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37642/#review95964
-----------------------------------------------------------



docs/learn/documentation/versioned/jobs/logging.md (line 100)
<https://reviews.apache.org/r/37642/#comment151153>

    can it be something like "and change name of log stream with param 'StreamName'". Because this is not the StreamAppender's name.



docs/learn/documentation/versioned/jobs/logging.md (line 104)
<https://reviews.apache.org/r/37642/#comment151154>

    how about adding a comment  "<!-- optional -->" here?


- Yan Fang


On Aug. 20, 2015, 9:25 a.m., Aleksandar Pejakovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37642/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2015, 9:25 a.m.)
> 
> 
> Review request for samza.
> 
> 
> Repository: samza
> 
> 
> Description
> -------
> 
> Added requested param to logging.md
> 
> 
> Diffs
> -----
> 
>   docs/learn/documentation/versioned/jobs/logging.md d1b372c 
> 
> Diff: https://reviews.apache.org/r/37642/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Aleksandar Pejakovic
> 
>