You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lenya.apache.org by Jörn Nettingsmeier <ne...@apache.org> on 2007/05/19 15:47:17 UTC
how about getting rid of the "rendertype" parameter..
hi everyone!
currently, we use the "rendertype" parameter to provide editor-specific
hacks. imho, we should get rid of it for 1.4.1, for a number of reasons:
* introduces needless complexity in the publication sitemap
* violates SoC since doctype modules must provide editor hacks (see
modules/xhtml/xslt/xhtml2xhtml.xsl: the XHTML module puts in a
bxe-specific tag. same goes for the homepage module.
* does roughly the same as doctype formats, but in an inconsistent way
all other doctype modules pass the parameter on to their xhtml2xhtml
stylesheets, but do nothing with it. many lines of code can be removed.
i guess that tinymce demonstrates that there is no need for global
editor hacks - they can be added in a module sitemap just as easily,
without polluting global sitemaps and SoC violations.
i'd like to file this issue as a "critical" bug for 1.4.1. wdyt?
regards,
jörn
--
Jörn Nettingsmeier
Kurt is up in heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: how about getting rid of the "rendertype" parameter..
Posted by Jörn Nettingsmeier <ne...@apache.org>.
Andreas Hartmann wrote:
> But how should we determine whether to add the bxe_xpath attribute
> without using the rendertype parameter? The BXE-editable areas depend
> on the resource type.
currently we do not provide support for multiple editable areas by
default. to do that in an editor-agnostic way, we could alter our
storage format to allow multiple "body" sections or add a "collection"
type document that aggregates multiple single editable sections, which
would be plain xhtml doctypes. this needs careful consideration. but it
does not have any implications to removing the rendertype parameter iiuc
(see below).
> Maybe we can add the bxe_xpath attributes by
> default and filter them out for the view mode in a single place,
> preferrably in the bxe module?
-1. as a tinymce fan, i absolutely do not care about spurious hacks for
other editors in my data :)
if we use pipeline usecase views for bxe (like tinymce does), doing some
preprocessing to add bxe requirements is trivial. since it happens in
src/modules/bxe/sitemap.xmap, SoC is honored and doctype modules can be
editor-agnostic.
if people want to use bxe's capabilities to edit and render arbitrary
xml doctypes, they will perhaps have to introduce a new module that does
indeed have bxe specifics in it, but for generic xhtml, it is not necessary.
>> i'd like to file this issue as a "critical" bug for 1.4.1. wdyt?
>
> We should definitely think about this issue, but I don't think it is
> critical.
it's an architectural ball-and-chain we should get rid of, and i chose
"critical" to make it visible on the radar, but i agree stuff such as
this is still somewhat cosmetic in the short term and should not delay
any releases.
--
Jörn Nettingsmeier
Kurt is up in heaven now.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: how about getting rid of the "rendertype" parameter..
Posted by Andreas Hartmann <an...@apache.org>.
Jörn Nettingsmeier schrieb:
> hi everyone!
>
>
> currently, we use the "rendertype" parameter to provide editor-specific
> hacks. imho, we should get rid of it for 1.4.1, for a number of reasons:
>
> * introduces needless complexity in the publication sitemap
> * violates SoC since doctype modules must provide editor hacks (see
> modules/xhtml/xslt/xhtml2xhtml.xsl: the XHTML module puts in a
> bxe-specific tag. same goes for the homepage module.
I agree to these concerns.
But how should we determine whether to add the bxe_xpath attribute
without using the rendertype parameter? The BXE-editable areas depend
on the resource type. Maybe we can add the bxe_xpath attributes by
default and filter them out for the view mode in a single place,
preferrably in the bxe module?
> * does roughly the same as doctype formats, but in an inconsistent way
> all other doctype modules pass the parameter on to their xhtml2xhtml
> stylesheets, but do nothing with it. many lines of code can be removed.
>
> i guess that tinymce demonstrates that there is no need for global
> editor hacks - they can be added in a module sitemap just as easily,
> without polluting global sitemaps and SoC violations.
>
> i'd like to file this issue as a "critical" bug for 1.4.1. wdyt?
We should definitely think about this issue, but I don't think it is
critical.
-- Andreas
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: how about getting rid of the "rendertype" parameter..
Posted by Andreas Hartmann <an...@apache.org>.
Michael Ralston schrieb:
> I think the news module uses the rendertype parameter to generate the
> rss feed?
The rendertype parameter was just left from copy&paste.
I removed it from the news module, thanks for the pointer!
-- Andreas
>
> MR
>
> On 5/19/07, *Jörn Nettingsmeier* < nettings@apache.org
> <ma...@apache.org>> wrote:
>
> hi everyone!
>
>
> currently, we use the "rendertype" parameter to provide editor-specific
> hacks. imho, we should get rid of it for 1.4.1, for a number of reasons:
>
> * introduces needless complexity in the publication sitemap
> * violates SoC since doctype modules must provide editor hacks (see
> modules/xhtml/xslt/xhtml2xhtml.xsl: the XHTML module puts in a
> bxe-specific tag. same goes for the homepage module.
> * does roughly the same as doctype formats, but in an inconsistent way
>
> all other doctype modules pass the parameter on to their xhtml2xhtml
> stylesheets, but do nothing with it. many lines of code can be removed.
>
> i guess that tinymce demonstrates that there is no need for global
> editor hacks - they can be added in a module sitemap just as easily,
> without polluting global sitemaps and SoC violations.
>
> i'd like to file this issue as a "critical" bug for 1.4.1. wdyt?
>
>
> regards,
>
> jörn
>
>
> --
> Jörn Nettingsmeier
>
> Kurt is up in heaven now.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> <ma...@lenya.apache.org>
> For additional commands, e-mail: dev-help@lenya.apache.org
> <ma...@lenya.apache.org>
>
>
--
Andreas Hartmann, CTO
BeCompany GmbH
http://www.becompany.ch
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org
Re: how about getting rid of the "rendertype" parameter..
Posted by Michael Ralston <mi...@kcms.com.au>.
I think the news module uses the rendertype parameter to generate the rss
feed?
MR
On 5/19/07, Jörn Nettingsmeier <ne...@apache.org> wrote:
>
> hi everyone!
>
>
> currently, we use the "rendertype" parameter to provide editor-specific
> hacks. imho, we should get rid of it for 1.4.1, for a number of reasons:
>
> * introduces needless complexity in the publication sitemap
> * violates SoC since doctype modules must provide editor hacks (see
> modules/xhtml/xslt/xhtml2xhtml.xsl: the XHTML module puts in a
> bxe-specific tag. same goes for the homepage module.
> * does roughly the same as doctype formats, but in an inconsistent way
>
> all other doctype modules pass the parameter on to their xhtml2xhtml
> stylesheets, but do nothing with it. many lines of code can be removed.
>
> i guess that tinymce demonstrates that there is no need for global
> editor hacks - they can be added in a module sitemap just as easily,
> without polluting global sitemaps and SoC violations.
>
> i'd like to file this issue as a "critical" bug for 1.4.1. wdyt?
>
>
> regards,
>
> jörn
>
>
> --
> Jörn Nettingsmeier
>
> Kurt is up in heaven now.
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
> For additional commands, e-mail: dev-help@lenya.apache.org
>
>