You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Alok Lal <al...@hortonworks.com> on 2015/03/11 23:34:08 UTC
Review Request 31959: RANGER-299 Service def validations
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31959/
-----------------------------------------------------------
Review request for ranger.
Bugs: RANGER-299
https://issues.apache.org/jira/browse/RANGER-299
Repository: ranger
Description
-------
Validations for service def
Diffs
-----
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java 941bb21
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceValidator.java 11e2682
security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java b6948dc
security-admin/src/main/java/org/apache/ranger/rest/RangerValidatorFactory.java 01b0a7e
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java be52892
security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java PRE-CREATION
security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java d3ee6d6
security-admin/src/test/java/org/apache/ranger/rest/TestServiceRESTForValidation.java da15ffa
security-admin/src/test/java/org/apache/ranger/rest/ValidationTestUtils.java b734763
Diff: https://reviews.apache.org/r/31959/diff/
Testing
-------
Additional junits and existing ones.
Thanks,
Alok Lal
Re: Review Request 31959: RANGER-299 Service def validations
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31959/#review76209
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java
<https://reviews.apache.org/r/31959/#comment123695>
Validation classes are placed in "org.apache.ranger.rest" package. Can this be moved to "org.apache.ranger.plugin.model.validation" package, in ranger-plugins-common.jar, where the validation can be used outside of the web-application.
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java
<https://reviews.apache.org/r/31959/#comment123691>
Please add validation for policyConditions and contextEnhancers.
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java
<https://reviews.apache.org/r/31959/#comment123692>
Please use case-insensitive comparision - to check for duplicate access-types/incorrect implied access grant.
- Madhan Neethiraj
On March 12, 2015, 1:24 a.m., Alok Lal wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31959/
> -----------------------------------------------------------
>
> (Updated March 12, 2015, 1:24 a.m.)
>
>
> Review request for ranger.
>
>
> Bugs: RANGER-299
> https://issues.apache.org/jira/browse/RANGER-299
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Validations for service def
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java 941bb21
> security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java PRE-CREATION
> security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java b6948dc
> security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java 4e15753
> security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java PRE-CREATION
> security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java d3ee6d6
>
> Diff: https://reviews.apache.org/r/31959/diff/
>
>
> Testing
> -------
>
> Additional junits and existing ones.
>
>
> Thanks,
>
> Alok Lal
>
>
Re: Review Request 31959: RANGER-299 Service def validations
Posted by Alok Lal <al...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31959/
-----------------------------------------------------------
(Updated March 11, 2015, 6:24 p.m.)
Review request for ranger.
Changes
-------
RANGER-304 Validation does several checks now in case-insensitive manner.
Check for parameter names of a service are left as is because making them case-insensitive would require corresponding changes in test-service code.
Junits were changed to excercise case-insesitive parts, i.e. they would fail if code wasn't doing case-insensitive comparison for both happypath and failure cases.
This change-set is applied as a "rework" of this review since it assumes that service-def validation code is committed in. Since that is still in review (and not committed in) it wasn't possible to create a review of just these changes. Hence, they are submitted here as a diff of service-def validation changes.
Bugs: RANGER-299
https://issues.apache.org/jira/browse/RANGER-299
Repository: ranger
Description
-------
Validations for service def
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/rest/RangerPolicyValidator.java 941bb21
security-admin/src/main/java/org/apache/ranger/rest/RangerServiceDefValidator.java PRE-CREATION
security-admin/src/main/java/org/apache/ranger/rest/RangerValidator.java b6948dc
security-admin/src/test/java/org/apache/ranger/rest/TestRangerPolicyValidator.java 4e15753
security-admin/src/test/java/org/apache/ranger/rest/TestRangerServiceDefValidator.java PRE-CREATION
security-admin/src/test/java/org/apache/ranger/rest/TestRangerValidator.java d3ee6d6
Diff: https://reviews.apache.org/r/31959/diff/
Testing
-------
Additional junits and existing ones.
Thanks,
Alok Lal