You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@fluo.apache.org by GitBox <gi...@apache.org> on 2020/01/15 16:32:21 UTC
[GitHub] [fluo-muchos] karthick-rn opened a new pull request #309: Enable
debug logging for Accumulo 2.0
karthick-rn opened a new pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309
This PR addresses #263. Through this change muchos by default will have debug logging enabled. Also, users who doesn't need debug logging can simply set 'debug_logging' to 'False' on the `muchos.props` template.
Unrelated to this PR but found during testing, copied the `hadoop-metrics2.properties` to `hadoop-ha/templates` which was missing originally.
Please review & let me know for any comments or suggestions.
Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request
#309: Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367474163
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
@karthick-rn it looks like I made this change in 496d73f4c7cc9f2c4752226c6a3df297decce355. For the testing use case I had, this existing change already satisfies that. I completely forgot about that change and did not close #263 as I should have. I don't think any additional changes are needed. I am so sorry for wasting your time!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] keith-turner merged pull request #309: Include
'hadoop-metrics2.properties' file for Hadoop HA roles
Posted by GitBox <gi...@apache.org>.
keith-turner merged pull request #309: Include 'hadoop-metrics2.properties' file for Hadoop HA roles
URL: https://github.com/apache/fluo-muchos/pull/309
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] keith-turner commented on a change in pull request
#309: Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
keith-turner commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367105837
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
When I run accumulo test I usually add a line like the following to `log4j-service.properties`
```
log4j.logger.org.apache.accumulo=DEBUG
```
This only enables debug logging for Accumulo code. The change `log4j.rootLogger=DEBUG, file` will enable debug logging for everything like Hadoop and Zookeeper. I am not sure how voluminous or useful this is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request
#309: Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367888942
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
@keith-turner No worries, I understand. Do you want me to submit a new PR for the `hadoop-metrics2.properties` that is missing in `/hadoop-ha/templates`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request
#309: Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367892396
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
Sounds good. I'll do it that way. Thanks @ctubbsii
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] ctubbsii commented on a change in pull request #309:
Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
ctubbsii commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367891938
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
@karthick-rn You could probably just change the title of this PR and repurpose it for that change. :smiley_cat:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [fluo-muchos] karthick-rn commented on a change in pull request
#309: Enable debug logging for Accumulo 2.0
Posted by GitBox <gi...@apache.org>.
karthick-rn commented on a change in pull request #309: Enable debug logging for Accumulo 2.0
URL: https://github.com/apache/fluo-muchos/pull/309#discussion_r367423481
##########
File path: ansible/roles/accumulo/tasks/main.yml
##########
@@ -61,3 +61,12 @@
creates: "{{ accumulo_home }}/lib/native/libaccumulo.so"
- name: "Create accumulo log dir"
file: path={{ worker_data_dirs[0] }}/logs/accumulo state=directory
+- name: "Enable debug logging in Accumulo 2.0"
+ replace:
+ path: "{{ accumulo_home }}/conf/{{ item }}"
+ regexp: '^log4j.rootLogger.*'
+ replace: "log4j.rootLogger=DEBUG, file"
Review comment:
https://github.com/apache/fluo-muchos/blob/c9a87f458972f93ecedd603662924ca0afd632fd/ansible/roles/accumulo/templates/log4j-service.properties#L34
@keith-turner Hi, Since the line was already there in `log4j-service.properties`, I was under the impression that #263 was to print all DEBUG level messages on Accumulo logs and so modified `log4j.rootLogger=DEBUG, file`. Let me know if there is further change required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services