You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2022/03/13 02:17:19 UTC
[GitHub] [bookkeeper] StevenLuMT opened a new pull request #3102: add stats for throttled-write
StevenLuMT opened a new pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102
Descriptions of the changes in this PR:
### Motivation
the method(triggerFlushAndAddEntry) cost time is changing,we need to focus on this method
### Changes
1.the previous counter metrics(throttledWriteRequests) are retained
2.add throttledWriteStats to record cost time and count for the method(triggerFlushAndAddEntry)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#issuecomment-1066007273
@dlg99 @eolivelli @pkumar-singh @zymap @hangc0276 @lordcheng10
If you have time, please help me review it, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#issuecomment-1066039729
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#discussion_r825432213
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageStats.java
##########
@@ -60,6 +60,7 @@
private static final String FLUSH_LEDGER_INDEX = "flush-ledger-index";
private static final String FLUSH_SIZE = "flush-size";
private static final String THROTTLED_WRITE_REQUESTS = "throttled-write-requests";
+ private static final String THROTTLED_WRITE = "throttled-write";
Review comment:
@hangc0276
I think it's no need to change name, throttled-write is OpStatsLogger, this prometheus metrics has two method: sum and count
1. throttled_write: throttled's latency
2. throttled_write_count: the count of throttled
3. throttled_write_sum: the sum throttled's latency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT removed a comment on pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT removed a comment on pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#issuecomment-1066030421
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#issuecomment-1066030421
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] StevenLuMT commented on a change in pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
StevenLuMT commented on a change in pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#discussion_r825432213
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageStats.java
##########
@@ -60,6 +60,7 @@
private static final String FLUSH_LEDGER_INDEX = "flush-ledger-index";
private static final String FLUSH_SIZE = "flush-size";
private static final String THROTTLED_WRITE_REQUESTS = "throttled-write-requests";
+ private static final String THROTTLED_WRITE = "throttled-write";
Review comment:
throttled-write is OpStatsLogger, this prometheus metrics has two method: sum and count
1. throttled_write: throttled's latency
2. throttled_write_count: the count of throttled
3. throttled_write_sum: the sum throttled's latency
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] hangc0276 commented on a change in pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
hangc0276 commented on a change in pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102#discussion_r825430889
##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/storage/ldb/DbLedgerStorageStats.java
##########
@@ -60,6 +60,7 @@
private static final String FLUSH_LEDGER_INDEX = "flush-ledger-index";
private static final String FLUSH_SIZE = "flush-size";
private static final String THROTTLED_WRITE_REQUESTS = "throttled-write-requests";
+ private static final String THROTTLED_WRITE = "throttled-write";
Review comment:
we'd better use `throttled-write-time` instead of `throttled-write` as metric name ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [bookkeeper] zymap merged pull request #3102: add stats for throttled-write
Posted by GitBox <gi...@apache.org>.
zymap merged pull request #3102:
URL: https://github.com/apache/bookkeeper/pull/3102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org