You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "teraearlywine (via GitHub)" <gi...@apache.org> on 2024/01/11 23:06:30 UTC

[I] Pendulum not importing correctly with certain lib [airflow]

teraearlywine opened a new issue, #36741:
URL: https://github.com/apache/airflow/issues/36741

   ### Apache Airflow version
   
   2.8.0
   
   ### If "Other Airflow 2 version" selected, which one?
   
   _No response_
   
   ### What happened?
   
   When importing airflow, breaking change with pendulum 3.0. Fixed the issue by from pendulum import tz etc.. 
   
   `The tz argument is keyword-only, unlike in version 1.x`
   https://pendulum.eustace.io/docs/
   
   ### What you think should happen instead?
   
   pendulum 3.0 was released last month
   
   ### How to reproduce
   
   install airflow locally and try running script with date used
   ```
   from airflow import DAG 
   schedule = "@once"
   
   ...
   dag = DAG(
       dag_id=dag_id,
       default_args=default_args,
       schedule_interval=schedule,
       catchup=False,
   )
   ```
   
   ### Operating System
   
   macOS
   
   ### Versions of Apache Airflow Providers
   
   _No response_
   
   ### Deployment
   
   Docker-Compose
   
   ### Deployment details
   
   _No response_
   
   ### Anything else?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Pendulum not importing correctly with certain lib [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk closed issue #36741: Pendulum not importing correctly with certain lib
URL: https://github.com/apache/airflow/issues/36741


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Pendulum not importing correctly with certain lib [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #36741:
URL: https://github.com/apache/airflow/issues/36741#issuecomment-1888159225

   BTW. We plan to cherry-pick it for 2.8.1 so likely 2.8.1 will be Pendulum-3 compatible


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Pendulum not importing correctly with certain lib [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on issue #36741:
URL: https://github.com/apache/airflow/issues/36741#issuecomment-1888154959

   You should use constraints to install airflow https://airflow.apache.org/docs/apache-airflow/stable/installation/installing-from-pypi.html - it is specifically designed to prevent people instaliing Airflow from experiencing such problems.
   
   That's why Airflow 2.8.0 has Pendulum <3 and I am quite surprised that you were able to install Airlfow 2.8.0 and Pendulum 3 together. This is what you find in Airflow 2.8.0 package metadata:
   
   ```
   Requires-Dist: pendulum (<3.0,>=2.0)
   ```
   
   You must have done something completely forbidden even if you used constraints.
   
   And yes we know very well tha tPendulum 3 is not ocmpatible with Airflow - but it has more breaking changes that you found.
   
   And if you'd search for Pendulum you'd find out that this PR https://github.com/apache/airflow/pull/36281 adds support for Pendulum 3.
   
   For the future I suggest you use search functionality first - that will save you time for reporting issues and maintainers for having to close them.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [I] Pendulum not importing correctly with certain lib [airflow]

Posted by "boring-cyborg[bot] (via GitHub)" <gi...@apache.org>.
boring-cyborg[bot] commented on issue #36741:
URL: https://github.com/apache/airflow/issues/36741#issuecomment-1888109126

   Thanks for opening your first issue here! Be sure to follow the issue template! If you are willing to raise PR to address this issue please do so, no need to wait for approval.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org