[jira] [Commented] (S2GRAPH-121) Create `Result` class to hold traverse result edges.

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/S2GRAPH-121?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664564#comment-15664564 ] 

ASF GitHub Bot commented on S2GRAPH-121:
----------------------------------------

GitHub user SteamShon opened a pull request:

    https://github.com/apache/incubator-s2graph/pull/96

    [S2GRAPH-121]: Create `Result` class to hold traverse result edges.

    - add StepResult to abstract traversal result.
    - change GroupBy, OrderBy, FilterOut logic from PostProcess and refactor PostProcess to only perform formatting.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/SteamShon/incubator-s2graph S2GRAPH-121

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-s2graph/pull/96.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #96
    
----
commit 4454188dce5c2044a919f42f373722f3eade79cf
Author: DO YUNG YOON <st...@apache.org>
Date:   2016-11-14T17:53:59Z

    [S2GRAPH-121]: Create `Result` class to hold traverse result edges.
    - add StepResult to abstract traversal result.
    - change GroupBy, OrderBy, FilterOut logic from PostProcess and refactor PostProcess to only perform formatting.

----


> Create `Result` class to hold traverse result edges.
> ----------------------------------------------------
>
>                 Key: S2GRAPH-121
>                 URL: https://issues.apache.org/jira/browse/S2GRAPH-121
>             Project: S2Graph
>          Issue Type: Improvement
>    Affects Versions: 0.2.0
>            Reporter: DOYUNG YOON
>            Assignee: DOYUNG YOON
>              Labels: refactoring
>             Fix For: 0.2.0
>
>   Original Estimate: 168h
>  Remaining Estimate: 168h
>
> Purpose of suggestion.
> GroupBy, OrderBy, Filtering implementation of fetched result edges are spread out multiple parts(Storage, AsynchbaseStorage, PostProcess). It would be much better we can separate post process logic(OrderBy, GroupBy, FilterOut) in `Result` class so any caller simply can benefit single implementation.
> In general, I am suggesting changing PostProcess only call method of Result class, not actually implement logic.
> I was asked if we can provide binary format(not JSON) such as protobuf, thrift, etc and I think it is reasonable demand. While I was tapping out possibility of this, I found out moving post process implementation into `Result` class can make this really easy, I guess we can simply focus on actual `format` not post process logic itself.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)