You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/05/26 11:17:55 UTC
[GitHub] [arrow] assignUser opened a new pull request, #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
assignUser opened a new pull request, #13241:
URL: https://github.com/apache/arrow/pull/13241
merge after #13149
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on code in PR #13241:
URL: https://github.com/apache/arrow/pull/13241#discussion_r882961723
##########
r/tools/distro-map.csv:
##########
@@ -0,0 +1,22 @@
+actual,use_this
+fedora-28,ubuntu-18.04
+fedora-29,ubuntu-18.04
+fedora-30,ubuntu-18.04
+fedora-31,ubuntu-18.04
+fedora-32,ubuntu-18.04
+fedora-33,ubuntu-18.04
+fedora-34,ubuntu-18.04
+centos-8,ubuntu-18.04
+rhel-8,ubuntu-18.04
+fedora-19,centos-7
+fedora-20,centos-7
+rhel-7,centos-7
+debian-10,ubuntu-18.04
+debian-11,ubuntu-18.04
+ubuntu-18.10,ubuntu-18.04
+ubuntu-19.04,ubuntu-18.04
+ubuntu-19.10,ubuntu-18.04
+ubuntu-20.04,ubuntu-18.04
+ubuntu-20.10,ubuntu-18.04
+ubuntu-21.04,ubuntu-18.04
+ubuntu-21.10,ubuntu-18.04
Review Comment:
This is missing https://github.com/ursa-labs/arrow-r-nightly/commit/bda16283a911d680c5a0481c39cebeb4379dc57d (see also https://github.com/apache/arrow/issues/13211)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1138844041
This should be merged once the upload to nightlies.apache.org is tested and working as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1138424887
:warning: Ticket **has no components in JIRA**, make sure you assign one.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1138424860
https://issues.apache.org/jira/browse/ARROW-16405
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on code in PR #13241:
URL: https://github.com/apache/arrow/pull/13241#discussion_r882962565
##########
r/tools/nixlibs.R:
##########
@@ -213,7 +213,7 @@ read_system_release <- function() {
find_available_binary <- function(os) {
# Download a csv that maps one to the other, columns "actual" and "use_this"
- u <- "https://raw.githubusercontent.com/ursa-labs/arrow-r-nightly/master/linux/distro-map.csv"
+ u <- "https://raw.githubusercontent.com/apache/arrow/master/r/tools/distro-map.csv"
lookup <- try(utils::read.csv(u, stringsAsFactors = FALSE), silent = quietly)
Review Comment:
Since the file is included in the package now, you could fall back to using the local copy. (I still think it is good to try to download since we can update the one on master.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1176229030
> After #13464 I think all you'll need here is the URL change.
Yep waiting for that to merge to update this :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13241:
URL: https://github.com/apache/arrow/pull/13241#discussion_r916278393
##########
r/vignettes/developers/install_details.Rmd:
##########
@@ -94,13 +94,14 @@ you'll need to install them before installing the R package.
If libarrow is not found on the system, the R package installation
script will next attempt to download prebuilt libarrow binaries
-that match your both your local operating system and arrow R package version.
-The libarrow binaries will only be retrieved if you have set the environment variable
-`LIBARROW_BINARY` or `NOT_CRAN`.
-
-If found, they will be downloaded and bundled when your R package compiles.
-For a list of supported distributions and versions,
-see the [arrow-r-nightly](https://github.com/ursa-labs/arrow-r-nightly/blob/master/README.md) project.
+that match your both your local operating system, required
+dependencies (e.g. openssl version) and arrow R package version.
+
+These are used automatically on many Linux distributions (x86_64 architecture only),
+according to the [allowlist](https://github.com/apache/arrow/blob/master/r/tools/nixlibs-allowlist.txt).
+If your distribution isn't in the list, you can opt-in by setting the `NOT_CRAN`
Review Comment:
Yeah same here, that's why I just reused what you had already added in the other vignette, even thought about just not mentioning it xD We can always change it prior to CRAN submission...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on a diff in pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
assignUser commented on code in PR #13241:
URL: https://github.com/apache/arrow/pull/13241#discussion_r916277103
##########
r/README.md:
##########
@@ -75,11 +75,11 @@ and thus are only available in R >= 4.0.
### Installing a development version
Development versions of the package (binary and source) are built
-nightly and hosted at <https://arrow-r-nightly.s3.amazonaws.com>. To
+nightly and hosted at <https://nightlies.apache.org/arrow/r>. To
Review Comment:
oh good catch!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1176279019
Merged now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] assignUser commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
assignUser commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1178232198
Thanks for the review!
I ran `urlchecker` to be sure that we got all trailing slashes and aside from the non-canonical cran link this pops up
```
x Error: README.md:5:75 400: Bad Request
[](https://anaconda.org/conda-forge/r-arrow)
```
But that line hasn't been touched in 2 years (and you remove the badges prior to submission iirc?).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1178245776
Yeah I usually remember to remove badges prior to submission (having been bitten by their flakiness in the past)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson merged pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson merged PR #13241:
URL: https://github.com/apache/arrow/pull/13241
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1138424904
:warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on a diff in pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on code in PR #13241:
URL: https://github.com/apache/arrow/pull/13241#discussion_r916267584
##########
r/NEWS.md:
##########
@@ -19,6 +19,8 @@
# arrow 8.0.0.9000
+* The `arrow.dev_repo` for nightly builds of the R package and prebuilt
+ ibarrow binaries is now https://nightlies.apache.org/arrow/r.
Review Comment:
```suggestion
libarrow binaries is now https://nightlies.apache.org/arrow/r/.
```
##########
docs/source/developers/guide/resources.rst:
##########
@@ -55,7 +55,7 @@ Additional information
It is possible to install the Arrow R package from the nightly builds which are daily development
builds of the R package and are not the official releases. See more on the
- `Install R package article <https://ursalabs.org/arrow-r-nightly/articles/install.html#install-the-nightly-build>`_.
+ `Install R package article <https://arrow.apache.org/docs/r/articles/install.html#install-the-nightly-build>`_.
Review Comment:
Previously this pointed to the nightly docs, which I guess makes sense because this is about the nightly packages and the installation instructions for those may change, well, nightly. Is it worth keeping the nightly docs URL?
```suggestion
`Install R package article <https://arrow.apache.org/docs/dev/r/articles/install.html#install-the-nightly-build>`_.
```
##########
r/vignettes/developers/setup.Rmd:
##########
@@ -45,14 +45,13 @@ recent version of the library without building from source.
### Linux
On Linux, you can download a .zip file containing libarrow from the
-nightly repository.
+[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin).
Review Comment:
```suggestion
[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/).
```
##########
r/README.md:
##########
@@ -75,11 +75,11 @@ and thus are only available in R >= 4.0.
### Installing a development version
Development versions of the package (binary and source) are built
-nightly and hosted at <https://arrow-r-nightly.s3.amazonaws.com>. To
+nightly and hosted at <https://nightlies.apache.org/arrow/r>. To
Review Comment:
https://nightlies.apache.org/arrow/r does a 301 redirect to https://nightlies.apache.org/arrow/r/ so everywhere there is a URL that CRAN may check, we need the trailing slash.
```suggestion
nightly and hosted at <https://nightlies.apache.org/arrow/r/>. To
```
##########
r/vignettes/developers/install_details.Rmd:
##########
@@ -94,13 +94,14 @@ you'll need to install them before installing the R package.
If libarrow is not found on the system, the R package installation
script will next attempt to download prebuilt libarrow binaries
-that match your both your local operating system and arrow R package version.
-The libarrow binaries will only be retrieved if you have set the environment variable
-`LIBARROW_BINARY` or `NOT_CRAN`.
-
-If found, they will be downloaded and bundled when your R package compiles.
-For a list of supported distributions and versions,
-see the [arrow-r-nightly](https://github.com/ursa-labs/arrow-r-nightly/blob/master/README.md) project.
+that match your both your local operating system, required
+dependencies (e.g. openssl version) and arrow R package version.
+
+These are used automatically on many Linux distributions (x86_64 architecture only),
+according to the [allowlist](https://github.com/apache/arrow/blob/master/r/tools/nixlibs-allowlist.txt).
+If your distribution isn't in the list, you can opt-in by setting the `NOT_CRAN`
Review Comment:
Could also note here that we welcome PRs to add distros to the allowlist. Although I'm nervous about calling *too* much attention to this feature in the package itself.
##########
r/vignettes/developers/setup.Rmd:
##########
@@ -69,19 +68,13 @@ brew install apache-arrow --HEAD
### Windows
-On Windows, you can download a .zip file containing libarrow from the nightly repository.
-
-To see what nightlies are available, you can use arrow's (or any other S3 client's) S3 listing functionality to see what is in the bucket `s3://arrow-r-nightly/libarrow/bin`:
+On Windows, you can download a .zip file containing libarrow from the
+[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/windows).
Review Comment:
```suggestion
[nightly repository](https://nightlies.apache.org/arrow/r/libarrow/bin/windows/).
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] nealrichardson commented on pull request #13241: ARROW-16405: [R][CI] Use nightlies.apache.org as dev repo
Posted by GitBox <gi...@apache.org>.
nealrichardson commented on PR #13241:
URL: https://github.com/apache/arrow/pull/13241#issuecomment-1176222684
After #13464 I think all you'll need here is the URL change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org