You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by "timgrein (via GitHub)" <gi...@apache.org> on 2024/07/23 21:01:16 UTC
[PR] Use helper method setting up connection throughout whole ElasticSearchAdapterTest [calcite]
timgrein opened a new pull request, #3881:
URL: https://github.com/apache/calcite/pull/3881
I'm working on the `LIKE` operator for Elasticsearch and noticed that the `ElasticSearchAdapterTests` are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the `LIKE` operator PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use helper method setting up connection throughout whole ElasticSearchAdapterTest [calcite]
Posted by "caicancai (via GitHub)" <gi...@apache.org>.
caicancai commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2246732887
> I'm working on the `LIKE` operator for Elasticsearch and noticed that the `ElasticSearchAdapterTests` are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the `LIKE` operator PR.
I think this change can create a jira case to illustrate it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use helper method setting up connection throughout whole ElasticSearchAdapterTest [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2246890001
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3881) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3881&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3881&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3881&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3881&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3881&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3881)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6497] Use helper setup method throughout whole ElasticsearchAdapterTest [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando merged PR #3881:
URL: https://github.com/apache/calcite/pull/3881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use helper method setting up connection throughout whole ElasticSearchAdapterTest [calcite]
Posted by "asolimando (via GitHub)" <gi...@apache.org>.
asolimando commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2247457792
> > I'm working on the `LIKE` operator for Elasticsearch and noticed that the `ElasticSearchAdapterTests` are not using a helper method setting up a connection to Elasticsearch consistently, but rather duplicate code sometimes. I want to keep the change separate to not clutter the diff in the `LIKE` operator PR.
>
> I think this change can create a jira case to illustrate it.
>
> I see no need to create jira case mainly just fixing some typos and adding some simple tests
Agreed, please create a Jira ticket @timgrein, direct PRs are for really minor fixes like typos etc., this one it's worth a ticket IMO
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Use helper method setting up connection throughout whole ElasticSearchAdapterTest [calcite]
Posted by "timgrein (via GitHub)" <gi...@apache.org>.
timgrein commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2247645426
> Agreed, please create a Jira ticket @timgrein, direct PRs are for really minor fixes like typos etc., this one it's worth a ticket IMO
Gotcha, then I'll create a ticket for this PR and wire it together accordingly!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6497] Use helper setup method throughout whole ElasticsearchAdapterTest [calcite]
Posted by "sonarcloud[bot] (via GitHub)" <gi...@apache.org>.
sonarcloud[bot] commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2248075214
## [](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3881) **Quality Gate passed**
Issues
 [0 New issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3881&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0 Accepted issues](https://sonarcloud.io/project/issues?id=apache_calcite&pullRequest=3881&issueStatuses=ACCEPTED)
Measures
 [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_calcite&pullRequest=3881&issueStatuses=OPEN,CONFIRMED&sinceLeakPeriod=true)
 [0.0% Coverage on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3881&metric=new_coverage&view=list)
 [0.0% Duplication on New Code](https://sonarcloud.io/component_measures?id=apache_calcite&pullRequest=3881&metric=new_duplicated_lines_density&view=list)
[See analysis details on SonarCloud](https://sonarcloud.io/dashboard?id=apache_calcite&pullRequest=3881)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [CALCITE-6497] Use helper setup method throughout whole ElasticsearchAdapterTest [calcite]
Posted by "timgrein (via GitHub)" <gi...@apache.org>.
timgrein commented on PR #3881:
URL: https://github.com/apache/calcite/pull/3881#issuecomment-2247872366
Created the ticket https://issues.apache.org/jira/browse/CALCITE-6497 and adjusted the commit message (force-push) to follow the official pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org