[GitHub] guacamole-server pull request #208: GUACAMOLE-662: Correct behavior of neste...

[mike-jumper <gi...@git.apache.org>]

GitHub user mike-jumper opened a pull request:

    https://github.com/apache/guacamole-server/pull/208

    GUACAMOLE-662: Correct behavior of nested socket.

    The nested `guac_socket` implementation has apparently been broken for some time. Besides the index not being properly initialized, the data written to the socket is (incorrectly) immediately flushed as a "nest" instruction. This behavior has resulted in the nested socket unit test failing.
    
    These changes correct the above, properly initializing the socket index and properly buffering UTF-8 data for eventual flushing as "nest" instructions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-jumper/guacamole-server fix-nest

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/guacamole-server/pull/208.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #208
    
----
commit 47ad6f4b59dc861ae8f17e41885c7f2947ff2bad
Author: Michael Jumper <mj...@...>
Date:   2019-01-06T23:43:55Z

    GUACAMOLE-662: Properly initialize nested socket index (fixes GUACAMOLE-510).

commit cc4671d7a168cd7424282f9b4be7b59cc1ee36a2
Author: Michael Jumper <mj...@...>
Date:   2019-01-07T01:06:45Z

    GUACAMOLE-662: Correct handling of buffering within nested socket.
    
    The nested socket implementation seems to have never been properly
    updated since guac_socket was changed to rely on implementation-specific
    buffering. This meant that absolutely every write resulted in a nest
    instruction being sent to the parent socket.
    
    Data should instead be built up within the internal buffer, with each
    flush writing as much of the internal buffer as possible within a nest
    instruction, leaving any partial UTF-8 characters at the end of the
    buffer for later completion with future writes.

----


---

[GitHub] guacamole-server pull request #208: GUACAMOLE-662: Correct behavior of neste...

[asfgit <gi...@git.apache.org>]

Github user asfgit closed the pull request at:

    https://github.com/apache/guacamole-server/pull/208


---