[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #1257: [VMware DRS] Adding new host to DRS cluster does not participate in load balancing.

[GitBox <gi...@apache.org>]

DaanHoogland commented on a change in pull request #1257:
URL: https://github.com/apache/cloudstack/pull/1257#discussion_r692738225



##########
File path: vmware-base/src/main/java/com/cloud/hypervisor/vmware/mo/HostMO.java
##########
@@ -1156,6 +1194,41 @@ public String getNetworkName(String netMorVal) throws Exception {
         return networkName;
     }
 
+    public void createPortGroup(HostPortGroupSpec spec) throws Exception {
+        if (spec == null) {
+            return;
+        }
+
+        synchronized (_mor.getValue().intern()) {

Review comment:
       can you explain why you synchronise on this object @sureshanaparti ? Intuitively I'd say just on the `HostMO` instance you want to add to the portgoup, i.e. `_mor`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org