You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/17 09:15:52 UTC
[GitHub] [apisix-go-plugin-runner] rampagecong opened a new issue #67: Question #62 whether Apisix version 2.12 can be implemented?
rampagecong opened a new issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67
### Issue description
Can #62 be implemented if you rewrite apisix-go-plugin-runne yourself? The technical plan for the company project should be made. If it can't be realized, the technical plan can only be changed.
### Environment
* APISIX Go Plugin Runner's version:
* APISIX version:
* Go version:
* OS (cmd: `uname -a`):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
rampagecong commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1047529416
Could you please take a look at those commits that implement the response header setting:
https://github.com/rampagecong/apisix-go-plugin-runner/commit/950a4d46e2f89f2b7093196f3c085c42b4fc84c6
https://github.com/rampagecong/ext-plugin-proto/commit/0fc113f3bd182ad3fed12fc63e236c82bca253dc
https://github.com/rampagecong/apisix/commit/83d505771ea10bd8999aea1009500c6a77741b22
I basically just add a resp_headers field to Req and Rewrite struct and regen the code.
Modified the FetchChanges method so that I can get the modified response header from the respHdr filed that I added to flatbuffer pb file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong edited a comment on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
rampagecong edited a comment on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1047529416
Could you please take a look at those commits that implement the response header setting:
https://github.com/rampagecong/apisix-go-plugin-runner/commit/d498697abb87b91002cdfabdc55f3cdc2b162328
https://github.com/rampagecong/ext-plugin-proto/commit/0fc113f3bd182ad3fed12fc63e236c82bca253dc
https://github.com/rampagecong/apisix/commit/83d505771ea10bd8999aea1009500c6a77741b22
I basically just add a resp_headers field to Req and Rewrite struct and regen the code.
Modified the FetchChanges method so that I can get the modified response header from the respHdr filed that I added to flatbuffer pb file.
@spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander closed issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander closed issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1043733317
It requires modifying APISIX. Are you interested in working on it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander edited a comment on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander edited a comment on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1048372323
Good. Could you submit them as Pull Request so that I can review them?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1063890721
Already done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
rampagecong commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1043753954
> It requires modifying APISIX. Are you interested in working on it?
Very interested, but what skills are required.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong edited a comment on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
rampagecong edited a comment on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1047529416
Could you please take a look at those commits that implement the response header setting:
https://github.com/rampagecong/apisix-go-plugin-runner/commit/950a4d46e2f89f2b7093196f3c085c42b4fc84c6
https://github.com/rampagecong/ext-plugin-proto/commit/0fc113f3bd182ad3fed12fc63e236c82bca253dc
https://github.com/rampagecong/apisix/commit/83d505771ea10bd8999aea1009500c6a77741b22
I basically just add a resp_headers field to Req and Rewrite struct and regen the code.
Modified the FetchChanges method so that I can get the modified response header from the respHdr filed that I added to flatbuffer pb file.
@spacewander
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1048372323
Good. Could you submit them as Pull Request so that I can review it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] spacewander commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
spacewander commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1043810606
You can
1. read the doc in https://github.com/apache/apisix/pull/6336
2. add a response header field to https://github.com/api7/ext-plugin-proto/blob/70ee1218b214fd206a8a949fb0f4f7d00f9e460f/ext-plugin.fbs#L102
3. generate the code
4. update APISIX to support it in https://github.com/apache/apisix/blob/9b98f1d13187c58195543bd48cb8b66e33aeab27/apisix/plugins/ext-plugin/init.lua#L601
5. update Go Plugin Runner to support it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-go-plugin-runner] rampagecong commented on issue #67: Question #62 whether Apisix version 2.12 can be implemented?
Posted by GitBox <gi...@apache.org>.
rampagecong commented on issue #67:
URL: https://github.com/apache/apisix-go-plugin-runner/issues/67#issuecomment-1043816677
Ok.I'll try it.thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org