[GitHub] [qpid-dispatch] jiridanek commented on a change in pull request #1223: Tsan fixes - do not merge!

[GitBox <gi...@apache.org>]

jiridanek commented on a change in pull request #1223:
URL: https://github.com/apache/qpid-dispatch/pull/1223#discussion_r634769900



##########
File path: tests/tsan.supp
##########
@@ -1,51 +1,91 @@
 # ThreadSanitizer (tsan) suppression file
 #
-race:libqpid-proton-proactor
-deadlock:libpython
+#race:libqpid-proton-proactor
+#deadlock:libpython
 
-race:qd_vlog_impl
-deadlock:qd_vlog_impl
-race:qd_log_entity
+# proton false positive?
+# TBD: discuss with proton devs
+deadlock:pni_timer_set

Review comment:
       Full disclosure ;P Deadlock detector in TSan appears to be lacking, https://github.com/google/sanitizers/issues/1258
   
   In LLVM Clang, there are two versions of the detector, that can be switched at compile time (of llvm).




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org