You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2022/11/04 13:14:15 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
lordgamez opened a new pull request, #1448:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1448
Pybind11 implemented support for Python 3.11 in version 2.10.1. Upgraded to this version to avoid CI and other build failures using Python 3.11 libs.
https://issues.apache.org/jira/browse/MINIFICPP-1977
-----------------------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
Posted by GitBox <gi...@apache.org>.
lordgamez commented on code in PR #1448:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1448#discussion_r1016883886
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -49,6 +45,17 @@ FOREACH(testfile ${EXECUTESCRIPT_PYTHON_TESTS})
createTests("${testfilename}")
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
+ # Copy test resources
+ add_custom_command(
Review Comment:
Good point, added comment in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -73,6 +80,17 @@ FOREACH(testfile ${EXECUTEPYTHONPROCESSOR_UNIT_TESTS})
createTests("${testfilename}")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
Review Comment:
Updated in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
##########
extensions/standard-processors/tests/CMakeLists.txt:
##########
@@ -48,14 +48,16 @@ FOREACH(testfile ${PROCESSOR_UNIT_TESTS})
MATH(EXPR PROCESSOR_INT_TEST_COUNT "${PROCESSOR_INT_TEST_COUNT}+1")
- # Copy test resources
- add_custom_command(
- TARGET "${testfilename}"
- POST_BUILD
- COMMAND ${CMAKE_COMMAND} -E copy_directory
- "${CMAKE_SOURCE_DIR}/extensions/standard-processors/tests/unit/resources"
- "$<TARGET_FILE_DIR:${testfilename}>/resources"
- )
+ if(PROCESSOR_INT_TEST_COUNT EQUAL 1)
Review Comment:
Updated in f0fa8ce115fe1c892e25d14d87b6bbb26c586f1f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
Posted by GitBox <gi...@apache.org>.
szaszm closed pull request #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
URL: https://github.com/apache/nifi-minifi-cpp/pull/1448
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on a diff in pull request #1448: MINIFICPP-1977 Upgrade pybind11 to support Python 3.11
Posted by GitBox <gi...@apache.org>.
szaszm commented on code in PR #1448:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1448#discussion_r1016820040
##########
extensions/standard-processors/tests/CMakeLists.txt:
##########
@@ -48,14 +48,16 @@ FOREACH(testfile ${PROCESSOR_UNIT_TESTS})
MATH(EXPR PROCESSOR_INT_TEST_COUNT "${PROCESSOR_INT_TEST_COUNT}+1")
- # Copy test resources
- add_custom_command(
- TARGET "${testfilename}"
- POST_BUILD
- COMMAND ${CMAKE_COMMAND} -E copy_directory
- "${CMAKE_SOURCE_DIR}/extensions/standard-processors/tests/unit/resources"
- "$<TARGET_FILE_DIR:${testfilename}>/resources"
- )
+ if(PROCESSOR_INT_TEST_COUNT EQUAL 1)
Review Comment:
same here
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -49,6 +45,17 @@ FOREACH(testfile ${EXECUTESCRIPT_PYTHON_TESTS})
createTests("${testfilename}")
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
+ # Copy test resources
+ add_custom_command(
Review Comment:
I think it would be helpful to explain why exactly this happens only on the first test, and not the others. Would you mind adding a comment about that?
Correct me if I'm wrong, but if I understand correctly, the build step of the first test target will copy all of the test resources to the build directory, where it will be accessible to all of the tests.
##########
extensions/script/tests/CMakeLists.txt:
##########
@@ -73,6 +80,17 @@ FOREACH(testfile ${EXECUTEPYTHONPROCESSOR_UNIT_TESTS})
createTests("${testfilename}")
add_test(NAME "${testfilename}" COMMAND "${testfilename}" WORKING_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR})
MATH(EXPR EXTENSIONS_TEST_COUNT "${EXTENSIONS_TEST_COUNT}+1")
+
+ if(EXTENSIONS_TEST_COUNT EQUAL 1)
Review Comment:
same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org