[GitHub] [solr-site] janhoy commented on a diff in pull request #77: Redirect rules to wire up the 9.0 guide

[GitBox <gi...@apache.org>]

janhoy commented on code in PR #77:
URL: https://github.com/apache/solr-site/pull/77#discussion_r866003493


##########
themes/solr/templates/htaccess.ref-guide-antora:
##########
@@ -0,0 +1,2 @@
+Redirect 302 /guide/solr/latest /guide/solr/9_0
+Redirect 302 /guide/solr/index.html /guide/solr/9_0/index.html

Review Comment:
   Question: When I generated the `.htaccess` file by Antora (solr-ref-guide/build/site/solr/.htaccess), it generated a file like this:
   ```
   Redirect 302 /guide/solr/latest /guide/solr/9_0
   Redirect 301 /guide/index.html /guide/solr/9_0/index.html
   ```
   
   The first one looks correct, but I cannot see how the second one is. The path `/guide/index.html` is currently occupied by our own website as a landing page for all guides (we'll still need that to link to pre-9.0 guides). Also, using a 301 permanent redirect for the index.html to a specific version looks fishy? That's why I changed it to 302 and the path in this PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@solr.apache.org
For additional commands, e-mail: issues-help@solr.apache.org