You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@accumulo.apache.org by mm...@apache.org on 2019/04/02 20:51:01 UTC
[accumulo] branch master updated: Move metrics registration to
master run.
This is an automated email from the ASF dual-hosted git repository.
mmiller pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/accumulo.git
The following commit(s) were added to refs/heads/master by this push:
new 0d96c84 Move metrics registration to master run.
new 1bf4291 Move metrics registration to master run. Fixes #1058
0d96c84 is described below
commit 0d96c84801457b19ee044f097067a730e642446a
Author: Ed Coleman <de...@etcoleman.com>
AuthorDate: Thu Mar 28 15:05:32 2019 -0400
Move metrics registration to master run.
Addresses issue 1058 - the registration of metrics should be independent of replication.
---
.../java/org/apache/accumulo/master/Master.java | 22 +++++++++++-----------
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/server/master/src/main/java/org/apache/accumulo/master/Master.java b/server/master/src/main/java/org/apache/accumulo/master/Master.java
index f8622de..17b14a8 100644
--- a/server/master/src/main/java/org/apache/accumulo/master/Master.java
+++ b/server/master/src/main/java/org/apache/accumulo/master/Master.java
@@ -1406,6 +1406,17 @@ public class Master
}
}, 0, 5000);
+ // Register metrics modules
+ MasterMetricsFactory factory = new MasterMetricsFactory(getConfiguration(), this);
+
+ int failureCount = factory.register();
+
+ if (failureCount > 0) {
+ log.info("Failed to register {} metrics modules", failureCount);
+ } else {
+ log.info("All metrics modules registered");
+ }
+
// The master is fully initialized. Clients are allowed to connect now.
masterInitialized.set(true);
@@ -1471,17 +1482,6 @@ public class Master
context.getZooReaderWriter().putPersistentData(
getZooKeeperRoot() + Constants.ZMASTER_REPLICATION_COORDINATOR_ADDR,
replAddress.address.toString().getBytes(UTF_8), NodeExistsPolicy.OVERWRITE);
-
- // Register metrics modules
- MasterMetricsFactory factory = new MasterMetricsFactory(getConfiguration(), this);
-
- int failureCount = factory.register();
-
- if (failureCount > 0) {
- log.info("Failed to register {} metrics modules", failureCount);
- } else {
- log.info("All metrics modules registered");
- }
return replAddress.server;
}