You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "dirrao (via GitHub)" <gi...@apache.org> on 2024/05/27 15:51:28 UTC
[PR] Chart Postgres:16.3.0 and airflow default version description: 2.9.1 update [airflow]
dirrao opened a new pull request, #39879:
URL: https://github.com/apache/airflow/pull/39879
Chart Postgres:16.3.0 and airflow default version description: 2.9.1 update
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update [airflow]
Posted by "dirrao (via GitHub)" <gi...@apache.org>.
dirrao commented on PR #39879:
URL: https://github.com/apache/airflow/pull/39879#issuecomment-2134351580
> I am not sure we want to change Postgres version "like that" without more serious testing and consideration and likely resulting in a significant note.
>
> There are certain consequences of changing Postgres version. In the past we had the case where changing Postgres version - see https://github.com/apache/airflow/blob/main/chart/RELEASE_NOTES.rst#airflow-helm-chart-1120-2024-02-11
>
> It would be great if testing of the scenario is performed and in case (which I believe it will be happening again) manual migration is neded we need to mention that in in a significant newsfragment - so that it lands in the relase notes: (https://github.com/apache/airflow/tree/main/chart/newsfragments)
>
> While using embedded Postgres is not recommended for "production" - we know a number of our users actually rely on it for various purposes - including development and testing, and while we do not aim to keep automated migration and backwards-compatibility, some way of warning them is necessary in case the migration requires some manual step.
Thanks. We have been using the Postgres 16. we haven't faced any issues during the upgrade from 13 to 16. However, we are using external Postgres. I will test it and update the documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update [airflow]
Posted by "jedcunningham (via GitHub)" <gi...@apache.org>.
jedcunningham commented on code in PR #39879:
URL: https://github.com/apache/airflow/pull/39879#discussion_r1628011777
##########
chart/Chart.yaml:
##########
@@ -76,8 +76,8 @@ annotations:
links:
- name: '#37197'
url: https://github.com/apache/airflow/pull/37197
- - description: 'Misc: Default airflow version to 2.8.3'
+ - description: 'Misc: Default airflow version to 2.9.1'
kind: changed
links:
- - name: '#38036'
- url: https://github.com/apache/airflow/pull/38036
+ - name: '#39433'
+ url: https://github.com/apache/airflow/pull/39433
Review Comment:
This will be done during the next release anyways, that's why it isn't done in those Airflow version bump PRs.
Said another way, this is just a different representation of the changelog for chart version 1.13.0.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update [airflow]
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #39879:
URL: https://github.com/apache/airflow/pull/39879#issuecomment-2134320400
I am not sure we want to change Postgres version "like that" without more serious testing and consideration and likely resulting in a significant note.
There are certain consequences of changing Postgres version. In the past we had the case where changing Postgres version - see https://github.com/apache/airflow/blob/main/chart/RELEASE_NOTES.rst#airflow-helm-chart-1120-2024-02-11
It would be great if testing of the scenario is performed and in case (which I believe it will be happening again) manual migration is neded we need to mention that in in a significant newsfragment - so that it lands in the relase notes: (https://github.com/apache/airflow/tree/main/chart/newsfragments)
While using embedded Postgres is not recommended for "production" - we know a number of our users actually rely on it for various purposes - including development and testing, and while we do not aim to keep automated migration and backwards-compatibility, some way of warning them is necessary in case the migration requires some manual step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #39879:
URL: https://github.com/apache/airflow/pull/39879#issuecomment-2241346568
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update [airflow]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #39879: Chart Postgres:15.4.1 and airflow default version description: 2.9.1 update
URL: https://github.com/apache/airflow/pull/39879
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org