You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/04/29 09:49:27 UTC
[GitHub] [netbeans] jtulach opened a new pull request, #4052: Alternative Standalone Sampler
jtulach opened a new pull request, #4052:
URL: https://github.com/apache/netbeans/pull/4052
Continuous work on https://github.com/enso-org/enso/pull/3389 has revealed that [it is not possible to exclude](https://github.com/enso-org/enso/pull/3389/commits/3fd211cf318448a0bb03a67e97c4219b78e4595e) five NetBeans libraries when using sampler module standalone. To address that this PR continues in https://github.com/apache/netbeans/pull/4047:
- d66ce57938eea2037648bb7ecc4d5f121476b598 duplicates the tests to check not only the `InternalSampler`, but also existing `CLISampler`
- 9f4ec39ed761ce5950a51b370061ed0f85e2aaf2 adds yet another `StandaloneSampler` and its test
The test creates own `ClassLoader` and loads just the sampler JAR, without dependencies on other NetBeans modules (so `Lookup` isn't available) and then performs the `AbstractSamplerBase` tests. This guarantees that all three samplers behaves the same.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] matthiasblaesing commented on pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #4052:
URL: https://github.com/apache/netbeans/pull/4052#issuecomment-1113929973
> > Curious why this is going into delivery and not master?
>
> I need Maven bits, so I'd like to get this into NetBeans 14.
I think the point that @neilcsmith-net was trying to make is, that this does not look like a PR helping to stabilize NB14. The description of the issues shows IMHO that these are feature changes, so that another dependency gets a lower number of dependencies.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4052:
URL: https://github.com/apache/netbeans/pull/4052#issuecomment-1114233130
Yes, exactly what @matthiasblaesing said! This doesn't seem to fit the normal criteria for merges to delivery. Not that there's a problem with bending the rules occasionally, just like to see the reasoning (cost/benefit) in the PR for doing so.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4052:
URL: https://github.com/apache/netbeans/pull/4052#issuecomment-1113155715
Curious why this is going into delivery and not master?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni merged pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
ebarboni merged PR #4052:
URL: https://github.com/apache/netbeans/pull/4052
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] ebarboni commented on pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
ebarboni commented on PR #4052:
URL: https://github.com/apache/netbeans/pull/4052#issuecomment-1113208544
I accepted #4047 no more thinking on just accept bug fixes.
I merge this one as works for me + green and merge rc2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] JaroslavTulach commented on pull request #4052: Alternative Standalone Sampler
Posted by GitBox <gi...@apache.org>.
JaroslavTulach commented on PR #4052:
URL: https://github.com/apache/netbeans/pull/4052#issuecomment-1113925161
> Curious why this is going into delivery and not master?
I need Maven bits, so I'd like to get this into NetBeans 14.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists