You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/07/05 21:19:11 UTC

[GitHub] [tvm] Lunderberg commented on a diff in pull request #12011: [CI] Allow command-line argument or TVM_BUILD_PATH for C++ unittests

Lunderberg commented on code in PR #12011:
URL: https://github.com/apache/tvm/pull/12011#discussion_r914212595


##########
tests/scripts/ci.py:
##########
@@ -394,7 +396,9 @@ def fn(
         # Add named test suites
         for option_name, (_, extra_scripts) in options.items():
             if kwargs.get(option_name, False):
-                scripts += extra_scripts
+                scripts.extend(
+                    script.format(name=name, build_dir=build_dir) for script in extra_scripts

Review Comment:
   It currently isn't.  I had been thinking that the `task_config_build_{name}.sh` could be similarly handled in the formatting, but it didn't end up being necessary.  Updated as suggested, thank you!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org