You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Kevin Devroede <ke...@gmail.com> on 2016/02/17 23:03:34 UTC
Review Request 43676: Fixed variable shadowing in
HookManager::slavePreLaunchDockerHook.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/
-----------------------------------------------------------
Review request for mesos and haosdent huang.
Bugs: MESOS-4693
https://issues.apache.org/jira/browse/MESOS-4693
Repository: mesos
Description
-------
Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
Diffs
-----
src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42
src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae
Diff: https://reviews.apache.org/r/43676/diff/
Testing
-------
Thanks,
Kevin Devroede
Re: Review Request 43676: Fixed variable shadowing in
HookManager::slavePreLaunchDockerHook.
Posted by haosdent huang <ha...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119564
-----------------------------------------------------------
Ship it!
[~kdevroede] Your patch looks nice. Could you ask [~tnachen] or other committers whether he have cycles to shepherd you in this ticket? Then he could help you review and commit this.
- haosdent huang
On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:03 p.m.)
>
>
> Review request for mesos and haosdent huang.
>
>
> Bugs: MESOS-4693
> https://issues.apache.org/jira/browse/MESOS-4693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
>
>
> Diffs
> -----
>
> src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42
> src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae
>
> Diff: https://reviews.apache.org/r/43676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Devroede
>
>
Re: Review Request 43676: Fixed variable shadowing in
HookManager::slavePreLaunchDockerHook.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43676/#review119551
-----------------------------------------------------------
Patch looks great!
Reviews applied: [43676]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On Feb. 17, 2016, 10:03 p.m., Kevin Devroede wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43676/
> -----------------------------------------------------------
>
> (Updated Feb. 17, 2016, 10:03 p.m.)
>
>
> Review request for mesos and haosdent huang.
>
>
> Bugs: MESOS-4693
> https://issues.apache.org/jira/browse/MESOS-4693
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed variable shadowing in HookManager::slavePreLaunchDockerHook.
>
>
> Diffs
> -----
>
> src/hook/manager.hpp 8ab331ae28d29a006a7c9878ffb619f2cdd03a42
> src/hook/manager.cpp 704b166725c0b356f2acb9bb1539a72cefd9b7ae
>
> Diff: https://reviews.apache.org/r/43676/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Kevin Devroede
>
>