You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/24 06:47:57 UTC
[GitHub] [pulsar] tisonkun opened a new pull request, #18171: [fix][ci] Check full build artifacts licenses
tisonkun opened a new pull request, #18171:
URL: https://github.com/apache/pulsar/pull/18171
This closes #16783.
This closes #15253.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. Please attach the local preview screenshots (run `sh start.sh` at `pulsar/site2/website`) to your PR description, or else your PR might not get merged. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository: <!-- ENTER URL HERE -->
<!--
After opening this PR, the build in apache/pulsar will fail and instructions will
be provided for opening a PR in the PR author's forked repository.
apache/pulsar pull requests should be first tested in your own fork since the
apache/pulsar CI based on GitHub Actions has constrained resources and quota.
GitHub Actions provides separate quota for pull requests that are executed in
a forked repository.
The tests will be run in the forked repository until all PR review comments have
been handled, the tests pass and the PR is approved by a reviewer.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] Technoboy- merged pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
Technoboy- merged PR #18171:
URL: https://github.com/apache/pulsar/pull/18171
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#discussion_r1003043789
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -544,6 +544,10 @@ jobs:
-Pmain,docker -Dmaven.test.skip=true -Ddocker.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz
Review Comment:
No. In that step, we don't have a full-build tarball. See also discussions in #15253.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#issuecomment-1288858137
"Pulsar CI / Build Pulsar docker image" passed. I'm gonna rerun other tests later :(
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#issuecomment-1288638838
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] nodece commented on a diff in pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
nodece commented on code in PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#discussion_r1003037952
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -544,6 +544,10 @@ jobs:
-Pmain,docker -Dmaven.test.skip=true -Ddocker.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz
Review Comment:
I think you should move this command to `build-and-license-check` job.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on a diff in pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
tisonkun commented on code in PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#discussion_r1003043789
##########
.github/workflows/pulsar-ci.yaml:
##########
@@ -544,6 +544,10 @@ jobs:
-Pmain,docker -Dmaven.test.skip=true -Ddocker.squash=true \
-Dspotbugs.skip=true -Dlicense.skip=true -Dcheckstyle.skip=true -Drat.skip=true
+ # check full build artifacts licenses
+ - name: Check binary licenses
+ run: src/check-binary-license.sh ./distribution/server/target/apache-pulsar-*-bin.tar.gz
Review Comment:
No. In that step, we don't have a full-build tarball. See also #15253.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] tisonkun commented on pull request #18171: [fix][ci] Check full build artifacts licenses
Posted by GitBox <gi...@apache.org>.
tisonkun commented on PR #18171:
URL: https://github.com/apache/pulsar/pull/18171#issuecomment-1288954285
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org