You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2021/04/20 08:58:55 UTC
[GitHub] [orc] coderex2522 opened a new pull request #688: ORC-666: [C++] support a new TIMESTAMP_INSTANT type
coderex2522 opened a new pull request #688:
URL: https://github.com/apache/orc/pull/688
How was this patch tested?
1. Read and write tests for new TIMESTAMP_INSTANT type columns in unit test WriteTest.writeTimestampInstant
2. build type from the string containing the new TIMESTAMP_INSTANT type in unit test TestType.buildTypeFromString
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac merged pull request #688: ORC-666: [C++] support a new TIMESTAMP_INSTANT type
Posted by GitBox <gi...@apache.org>.
wgtmac merged pull request #688:
URL: https://github.com/apache/orc/pull/688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] coderex2522 commented on a change in pull request #688: ORC-666: [C++] support a new TIMESTAMP_INSTANT type
Posted by GitBox <gi...@apache.org>.
coderex2522 commented on a change in pull request #688:
URL: https://github.com/apache/orc/pull/688#discussion_r617213367
##########
File path: c++/src/TypeImpl.cc
##########
@@ -609,6 +614,8 @@ namespace orc {
return std::unique_ptr<Type>(new TypeImpl(BINARY));
} else if (category == "timestamp") {
return std::unique_ptr<Type>(new TypeImpl(TIMESTAMP));
+ } else if (category == "timestamp_with_local_time_zone") {
Review comment:
Done, the type name has been modified to be consistent with the Java side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [orc] wgtmac commented on a change in pull request #688: ORC-666: [C++] support a new TIMESTAMP_INSTANT type
Posted by GitBox <gi...@apache.org>.
wgtmac commented on a change in pull request #688:
URL: https://github.com/apache/orc/pull/688#discussion_r616772247
##########
File path: c++/src/TypeImpl.cc
##########
@@ -609,6 +614,8 @@ namespace orc {
return std::unique_ptr<Type>(new TypeImpl(BINARY));
} else if (category == "timestamp") {
return std::unique_ptr<Type>(new TypeImpl(TIMESTAMP));
+ } else if (category == "timestamp_with_local_time_zone") {
Review comment:
To be consistent with the Java side, the type name literal should remove the underscores: [commit](https://github.com/omalley/orc/blob/8289f7d2640833bba46be88941d1013eb2083023/java/core/src/java/org/apache/orc/TypeDescription.java#L124)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org