You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Feihong Huang (JIRA)" <ji...@apache.org> on 2013/08/28 05:05:59 UTC
[jira] [Commented] (SOLR-4877) SolrIndexSearcher#getDocSetNC should
check for null return in AtomicReader#fields()
[ https://issues.apache.org/jira/browse/SOLR-4877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13752047#comment-13752047 ]
Feihong Huang commented on SOLR-4877:
-------------------------------------
hi, Uwe,
I think the special handling of TermQuery just because of performance impact.
If we use the default search function in lucene such as "super.search(query,null,collector)",
it will create TermWeight for TermQuery to calculate queryNorm(q) and idf(t)2 * t.getBoost() and so on.
Therefore, i think the special handling of TermQuery is useful. Any comments?
> SolrIndexSearcher#getDocSetNC should check for null return in AtomicReader#fields()
> -----------------------------------------------------------------------------------
>
> Key: SOLR-4877
> URL: https://issues.apache.org/jira/browse/SOLR-4877
> Project: Solr
> Issue Type: Bug
> Affects Versions: 4.2, 4.3
> Reporter: Uwe Schindler
> Assignee: Uwe Schindler
> Fix For: 4.3.1, 4.4, 5.0
>
> Attachments: SOLR-4877-nospecialcase.patch, SOLR-4877.patch
>
>
> In LUCENE-5023 it was reported that composite reader contexts should not contain null fields() readers. But this is wrong, as a null-fields() reader may contain documents, just no fields.
> fields() and terms() is documented to return null, so DocSets should check for null (like all queries do in Lucene). It seems that DocSetNC does not correctly check for null.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org