[GitHub] dongjoon-hyun commented on a change in pull request #23931: [SPARK-26048][build] Enable flume profile when creating 2.x releases.

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #23931: [SPARK-26048][build] Enable flume profile when creating 2.x releases.
URL: https://github.com/apache/spark/pull/23931#discussion_r261731653
 
 

 ##########
 File path: dev/create-release/release-build.sh
 ##########
 @@ -116,14 +116,17 @@ SCALA_2_11_PROFILES=
 if [[ $SPARK_VERSION > "2.3" ]]; then
   BASE_PROFILES="$BASE_PROFILES -Pkubernetes"
   if [[ $SPARK_VERSION < "3.0." ]]; then
-    SCALA_2_11_PROFILES="-Pkafka-0-8"
+    SCALA_2_11_PROFILES="-Pkafka-0-8 -Pflume"
   fi
 
 Review comment:
   Hi, @vanzin , @dbtsai , @srowen , @cloud-fan .
   
   For `branch-2.4` release, I thought we are supposed to use `dev/create-release/release-build.sh` in `branch-2.4`.
   
   `branch-2.4` already has `-Pflume` [here](https://github.com/apache/spark/blob/branch-2.4/dev/create-release/release-build.sh#L117-L118). Is this PR aiming to use `master` branch code to do release `2.4.x`?
   ```bash
   if [[ $SPARK_VERSION > "2.3" ]]; then
     BASE_PROFILES="$BASE_PROFILES -Pkubernetes -Pflume"
     SCALA_2_11_PROFILES="-Pkafka-0-8"
   else
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org