You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/30 10:25:43 UTC

[GitHub] [incubator-superset] dpgaspar opened a new pull request #11114: Feat/api css crud

dpgaspar opened a new pull request #11114:
URL: https://github.com/apache/incubator-superset/pull/11114


   ### SUMMARY
   <!--- Describe the change below, including rationale and design decisions -->
   
   ### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
   <!--- Skip this if not applicable -->
   
   ### TEST PLAN
   <!--- What steps should be taken to verify the changes -->
   
   ### ADDITIONAL INFORMATION
   <!--- Check any relevant boxes with "x" -->
   <!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
   - [ ] Has associated issue:
   - [ ] Changes UI
   - [ ] Requires DB Migration.
   - [ ] Confirm DB Migration upgrade and downgrade tested.
   - [ ] Introduces new feature or API
   - [ ] Removes existing feature or API
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] dpgaspar merged pull request #11114: feat: CRUD REST API for CSS Templates

Posted by GitBox <gi...@apache.org>.
dpgaspar merged pull request #11114:
URL: https://github.com/apache/incubator-superset/pull/11114


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11114: feat: CRUD REST API for CSS Templates

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11114:
URL: https://github.com/apache/incubator-superset/pull/11114#issuecomment-701306992


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=h1) Report
   > Merging [#11114](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa5dab85c44fad34a665c44ed11255c28561cfda?el=desc) will **decrease** coverage by `4.51%`.
   > The diff coverage is `91.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11114/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11114      +/-   ##
   ==========================================
   - Coverage   65.75%   61.23%   -4.52%     
   ==========================================
     Files         818      824       +6     
     Lines       38783    38895     +112     
     Branches     3655     3655              
   ==========================================
   - Hits        25501    23817    -1684     
   - Misses      13173    14898    +1725     
   - Partials      109      180      +71     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `62.24% <ø> (ø)` | |
   | #python | `60.63% <91.30%> (-0.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/css\_templates/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9kYW8ucHk=) | `80.95% <80.95%> (ø)` | |
   | [superset/css\_templates/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `88.46% <88.46%> (ø)` | |
   | [superset/css\_templates/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9maWx0ZXJzLnB5) | `92.85% <92.85%> (ø)` | |
   | [superset/css\_templates/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.45% <95.45%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.45% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset-frontend/src/SqlLab/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL1NxbExhYi9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [superset-frontend/src/dashboard/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9BcHAuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | ... and [187 more](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=footer). Last update [fa5dab8...0fc09d4](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter commented on pull request #11114: feat: CRUD REST API for CSS Templates

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #11114:
URL: https://github.com/apache/incubator-superset/pull/11114#issuecomment-701306992


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=h1) Report
   > Merging [#11114](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa5dab85c44fad34a665c44ed11255c28561cfda?el=desc) will **decrease** coverage by `5.16%`.
   > The diff coverage is `91.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11114/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11114      +/-   ##
   ==========================================
   - Coverage   65.75%   60.58%   -5.17%     
   ==========================================
     Files         818      391     -427     
     Lines       38783    24447   -14336     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        25501    14811   -10690     
   + Misses      13173     9636    -3537     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.58% <91.30%> (-0.60%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/css\_templates/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9kYW8ucHk=) | `80.95% <80.95%> (ø)` | |
   | [superset/css\_templates/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `88.46% <88.46%> (ø)` | |
   | [superset/css\_templates/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9maWx0ZXJzLnB5) | `92.85% <92.85%> (ø)` | |
   | [superset/css\_templates/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.45% <95.45%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.45% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | ... and [447 more](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=footer). Last update [fa5dab8...0fc09d4](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] codecov-commenter edited a comment on pull request #11114: feat: CRUD REST API for CSS Templates

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #11114:
URL: https://github.com/apache/incubator-superset/pull/11114#issuecomment-701306992


   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=h1) Report
   > Merging [#11114](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/fa5dab85c44fad34a665c44ed11255c28561cfda?el=desc) will **decrease** coverage by `5.11%`.
   > The diff coverage is `91.30%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/11114/graphs/tree.svg?width=650&height=150&src=pr&token=KsB0fHcx6l)](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master   #11114      +/-   ##
   ==========================================
   - Coverage   65.75%   60.63%   -5.12%     
   ==========================================
     Files         818      391     -427     
     Lines       38783    24447   -14336     
     Branches     3655        0    -3655     
   ==========================================
   - Hits        25501    14824   -10677     
   + Misses      13173     9623    -3550     
   + Partials      109        0     -109     
   ```
   
   | Flag | Coverage Δ | |
   |---|---|---|
   | #cypress | `?` | |
   | #javascript | `?` | |
   | #python | `60.63% <91.30%> (-0.55%)` | :arrow_down: |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/css\_templates/dao.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9kYW8ucHk=) | `80.95% <80.95%> (ø)` | |
   | [superset/css\_templates/commands/bulk\_delete.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9idWxrX2RlbGV0ZS5weQ==) | `88.46% <88.46%> (ø)` | |
   | [superset/css\_templates/filters.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9maWx0ZXJzLnB5) | `92.85% <92.85%> (ø)` | |
   | [superset/css\_templates/api.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9hcGkucHk=) | `95.45% <95.45%> (ø)` | |
   | [superset/app.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXBwLnB5) | `80.45% <100.00%> (+0.15%)` | :arrow_up: |
   | [superset/css\_templates/commands/exceptions.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9jb21tYW5kcy9leGNlcHRpb25zLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/css\_templates/schemas.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY3NzX3RlbXBsYXRlcy9zY2hlbWFzLnB5) | `100.00% <100.00%> (ø)` | |
   | [superset/db\_engines/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
   | [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `53.90% <0.00%> (-30.08%)` | :arrow_down: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `69.76% <0.00%> (-12.32%)` | :arrow_down: |
   | ... and [445 more](https://codecov.io/gh/apache/incubator-superset/pull/11114/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=footer). Last update [fa5dab8...0fc09d4](https://codecov.io/gh/apache/incubator-superset/pull/11114?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org