You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/10/11 10:16:14 UTC
[GitHub] [pulsar] coderzc opened a new pull request, #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
coderzc opened a new pull request, #18000:
URL: https://github.com/apache/pulsar/pull/18000
### Motivation
In the InMemoryDelayedDeliveryTracker, the `priorityQueue` should be closed after the `timeout` task is canceled, otherwise, we may operate the `priorityQueue` that has been closed.
### Modifications
Close the `priorityQueue` after the `timeout` task is canceled.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
### Matching PR in forked repository
PR in forked repository:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #18000:
URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1275753996
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui closed pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
codelipenghui closed pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
URL: https://github.com/apache/pulsar/pull/18000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codelipenghui merged pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
codelipenghui merged PR #18000:
URL: https://github.com/apache/pulsar/pull/18000
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #18000:
URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1275819158
> Can we add a test for it?
I add `testClose` to cover this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #18000:
URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1276949086
/pulsarbot run-failure-checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] codecov-commenter commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on PR #18000:
URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1275503488
# [Codecov](https://codecov.io/gh/apache/pulsar/pull/18000?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> :exclamation: No coverage uploaded for pull request base (`master@9281bbd`). [Click here to learn what that means](https://docs.codecov.io/docs/error-reference?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#section-missing-base-commit).
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #18000 +/- ##
=========================================
Coverage ? 70.74%
Complexity ? 437
=========================================
Files ? 26
Lines ? 2246
Branches ? 245
=========================================
Hits ? 1589
Misses ? 484
Partials ? 173
```
| Flag | Coverage Δ | |
|---|---|---|
| unittests | `70.74% <0.00%> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar] coderzc commented on pull request #18000: [fix][broker] Fix the order of resource close in the InMemoryDelayedDeliveryTracker
Posted by GitBox <gi...@apache.org>.
coderzc commented on PR #18000:
URL: https://github.com/apache/pulsar/pull/18000#issuecomment-1275751365
> Can we add a test for it?
It seems hard to construct this case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org