You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/05/13 06:56:07 UTC

[GitHub] [flink] sunjincheng121 opened a new pull request #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie…

sunjincheng121 opened a new pull request #8423: [FLINK-12495][python, client]Move PythonGatewayServer into flink-clie…
URL: https://github.com/apache/flink/pull/8423
 
 
   ## What is the purpose of the change
   
   Due to we add py4j dependency for `PythonGatewayServer` when we put the `PythonGatewayServer` in `flink-core` module, and every module has a transitive dependency on `flink-core`, So It's better to move the `PythonGatewayServer` into `flink-clients`.
   
   ## Brief change log
   
     -  Move the `PythonGatewayServer` from `flink-core` to `flink-clients`.
     -  Move py4j dependency from `flink-core` to `flink-clients`.
     -  Modify the `java_gateway.py` script for package path of `PythonGatewayServer`.
   
   ## Verifying this change
   This change is a core moving without any test coverage.
   But we can run ` dev/lint-python.sh` to check the changes.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (no)
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: ( no)
     - The serializers: (yes / no / don't know)
     - The runtime per-record code paths (performance sensitive): ( no )
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: ( no )
     - The S3 file system connector: (no)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? ( no)
     - If yes, how is the feature documented? ( not documented)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services