You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/10/24 07:00:25 UTC

[GitHub] [dubbo] BurningCN opened a new pull request #9109: Add unit test for RpcStatus and fix TimeoutCountDown#elapsedMillis method

BurningCN opened a new pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109


   ## What is the purpose of the change
   1.add ut
   2.fix TimeoutCountDown#elapsedMillis method
   3.some code adjust
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter commented on pull request #9109: Fix TimeoutCountDown#elapsedMillis method and add some unit tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109#issuecomment-950278852


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9109](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f662c7c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/34f8fe3d60c026c6ba0de8e8fe75da66a19c83b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f8fe3) will **increase** coverage by `0.10%`.
   > The diff coverage is `52.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9109/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9109      +/-   ##
   ============================================
   + Coverage     64.36%   64.46%   +0.10%     
   + Complexity      314      311       -3     
   ============================================
     Files          1168     1177       +9     
     Lines         50194    50680     +486     
     Branches       7466     7520      +54     
   ============================================
   + Hits          32305    32673     +368     
   - Misses        14384    14437      +53     
   - Partials       3505     3570      +65     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `86.66% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.38% <0.00%> (-0.25%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/rpc/TimeoutCountDown.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9UaW1lb3V0Q291bnREb3duLmphdmE=) | `50.00% <50.00%> (+12.50%)` | :arrow_up: |
   | [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `35.22% <100.00%> (ø)` | |
   | [...ava/org/apache/dubbo/rpc/RpcContextAttachment.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0QXR0YWNobWVudC5qYXZh) | `84.37% <100.00%> (+2.55%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `83.76% <100.00%> (-0.67%)` | :arrow_down: |
   | [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ate/endpoint/metadata/DubboPropertiesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1Byb3BlcnRpZXNNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [189 more](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [34f8fe3...f662c7c](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] AlbumenJ merged pull request #9109: Fix TimeoutCountDown#elapsedMillis method and add some unit tests

Posted by GitBox <gi...@apache.org>.
AlbumenJ merged pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9109: Fix TimeoutCountDown#elapsedMillis method and add some unit tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109#issuecomment-950278852


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9109](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f662c7c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/34f8fe3d60c026c6ba0de8e8fe75da66a19c83b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f8fe3) will **increase** coverage by `0.37%`.
   > The diff coverage is `52.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9109/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9109      +/-   ##
   ============================================
   + Coverage     64.36%   64.73%   +0.37%     
   + Complexity      314      311       -3     
   ============================================
     Files          1168     1177       +9     
     Lines         50194    50715     +521     
     Branches       7466     7547      +81     
   ============================================
   + Hits          32305    32832     +527     
   + Misses        14384    14316      -68     
   - Partials       3505     3567      +62     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `86.66% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.38% <0.00%> (-0.25%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/rpc/TimeoutCountDown.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9UaW1lb3V0Q291bnREb3duLmphdmE=) | `50.00% <50.00%> (+12.50%)` | :arrow_up: |
   | [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `35.22% <100.00%> (ø)` | |
   | [...ava/org/apache/dubbo/rpc/RpcContextAttachment.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0QXR0YWNobWVudC5qYXZh) | `84.37% <100.00%> (+2.55%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `83.76% <100.00%> (-0.67%)` | :arrow_down: |
   | [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ate/endpoint/metadata/DubboPropertiesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1Byb3BlcnRpZXNNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [172 more](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [34f8fe3...f662c7c](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9109: Fix TimeoutCountDown#elapsedMillis method and add some unit tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109#issuecomment-950278852


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9109](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f662c7c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/34f8fe3d60c026c6ba0de8e8fe75da66a19c83b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f8fe3) will **increase** coverage by `0.35%`.
   > The diff coverage is `52.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9109/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9109      +/-   ##
   ============================================
   + Coverage     64.36%   64.71%   +0.35%     
   + Complexity      314      311       -3     
   ============================================
     Files          1168     1177       +9     
     Lines         50194    50715     +521     
     Branches       7466     7547      +81     
   ============================================
   + Hits          32305    32822     +517     
   + Misses        14384    14326      -58     
   - Partials       3505     3567      +62     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `86.66% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.38% <0.00%> (-0.25%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/rpc/TimeoutCountDown.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9UaW1lb3V0Q291bnREb3duLmphdmE=) | `50.00% <50.00%> (+12.50%)` | :arrow_up: |
   | [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `35.22% <100.00%> (ø)` | |
   | [...ava/org/apache/dubbo/rpc/RpcContextAttachment.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0QXR0YWNobWVudC5qYXZh) | `84.37% <100.00%> (+2.55%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `83.76% <100.00%> (-0.67%)` | :arrow_down: |
   | [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ate/endpoint/metadata/DubboPropertiesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1Byb3BlcnRpZXNNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [172 more](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [34f8fe3...f662c7c](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org

[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9109: Fix TimeoutCountDown#elapsedMillis method and add some unit tests

Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #9109:
URL: https://github.com/apache/dubbo/pull/9109#issuecomment-950278852


   # [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
   > Merging [#9109](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (f662c7c) into [3.0](https://codecov.io/gh/apache/dubbo/commit/34f8fe3d60c026c6ba0de8e8fe75da66a19c83b5?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (34f8fe3) will **increase** coverage by `0.15%`.
   > The diff coverage is `52.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/dubbo/pull/9109/graphs/tree.svg?width=650&height=150&src=pr&token=VnEIkiFQT0&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   
   ```diff
   @@             Coverage Diff              @@
   ##                3.0    #9109      +/-   ##
   ============================================
   + Coverage     64.36%   64.51%   +0.15%     
   + Complexity      314      311       -3     
   ============================================
     Files          1168     1177       +9     
     Lines         50194    50715     +521     
     Branches       7466     7547      +81     
   ============================================
   + Hits          32305    32720     +415     
   - Misses        14384    14432      +48     
   - Partials       3505     3563      +58     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
   |---|---|---|
   | [...c/main/java/org/apache/dubbo/rpc/RpcException.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNFeGNlcHRpb24uamF2YQ==) | `86.66% <ø> (ø)` | |
   | [...n/java/org/apache/dubbo/rpc/RpcServiceContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNTZXJ2aWNlQ29udGV4dC5qYXZh) | `64.38% <0.00%> (-0.25%)` | :arrow_down: |
   | [...in/java/org/apache/dubbo/rpc/TimeoutCountDown.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9UaW1lb3V0Q291bnREb3duLmphdmE=) | `50.00% <50.00%> (+12.50%)` | :arrow_up: |
   | [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `35.22% <100.00%> (ø)` | |
   | [...ava/org/apache/dubbo/rpc/RpcContextAttachment.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0QXR0YWNobWVudC5qYXZh) | `84.37% <100.00%> (+2.55%)` | :arrow_up: |
   | [...java/org/apache/dubbo/rpc/support/MockInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9zdXBwb3J0L01vY2tJbnZva2VyLmphdmE=) | `83.76% <100.00%> (-0.67%)` | :arrow_down: |
   | [.../boot/actuate/endpoint/metadata/DubboMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib01ldGFkYXRhLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...nfigure/DubboHealthIndicatorAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvSGVhbHRoSW5kaWNhdG9yQXV0b0NvbmZpZ3VyYXRpb24uamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...figure/DubboEndpointMetadataAutoConfiguration.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9hdXRvY29uZmlndXJlL0R1YmJvRW5kcG9pbnRNZXRhZGF0YUF1dG9Db25maWd1cmF0aW9uLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
   | [...ate/endpoint/metadata/DubboPropertiesMetadata.java](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tc3ByaW5nLWJvb3QvZHViYm8tc3ByaW5nLWJvb3QtY29tcGF0aWJsZS9hY3R1YXRvci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vc3ByaW5nL2Jvb3QvYWN0dWF0ZS9lbmRwb2ludC9tZXRhZGF0YS9EdWJib1Byb3BlcnRpZXNNZXRhZGF0YS5qYXZh) | `0.00% <0.00%> (-50.00%)` | :arrow_down: |
   | ... and [177 more](https://codecov.io/gh/apache/dubbo/pull/9109/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [34f8fe3...f662c7c](https://codecov.io/gh/apache/dubbo/pull/9109?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org