You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@carbondata.apache.org by ja...@apache.org on 2017/08/01 17:20:23 UTC
carbondata git commit: [CARBONDATA-1344] Remove useless variables
Repository: carbondata
Updated Branches:
refs/heads/master 2c4e6c45e -> f781337ea
[CARBONDATA-1344] Remove useless variables
remove aggTables & aggTableName
This closes #1216
Project: http://git-wip-us.apache.org/repos/asf/carbondata/repo
Commit: http://git-wip-us.apache.org/repos/asf/carbondata/commit/f781337e
Tree: http://git-wip-us.apache.org/repos/asf/carbondata/tree/f781337e
Diff: http://git-wip-us.apache.org/repos/asf/carbondata/diff/f781337e
Branch: refs/heads/master
Commit: f781337ea0a207a541c4d21a26286309225adfa8
Parents: 2c4e6c4
Author: lionelcao <wh...@gmail.com>
Authored: Mon Jul 31 09:14:34 2017 +0800
Committer: Jacky Li <ja...@qq.com>
Committed: Wed Aug 2 01:20:03 2017 +0800
----------------------------------------------------------------------
.../converter/ThriftWrapperSchemaConverterImpl.java | 7 -------
.../carbondata/processing/model/CarbonLoadModel.java | 10 ----------
2 files changed, 17 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/carbondata/blob/f781337e/core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
----------------------------------------------------------------------
diff --git a/core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java b/core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
index 745f477..2887d2a 100644
--- a/core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
+++ b/core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java
@@ -513,13 +513,6 @@ public class ThriftWrapperSchemaConverterImpl implements SchemaConverter {
wrapperTableInfo.setStorePath(storePath);
wrapperTableInfo.setFactTable(
fromExternalToWrapperTableSchema(externalTableInfo.getFact_table(), tableName));
- List<TableSchema> aggTablesList = new ArrayList<TableSchema>();
- int index = 0;
- for (org.apache.carbondata.format.TableSchema aggTable : externalTableInfo
- .getAggregate_table_list()) {
- aggTablesList.add(fromExternalToWrapperTableSchema(aggTable, "agg_table_" + index));
- index++;
- }
return wrapperTableInfo;
}
http://git-wip-us.apache.org/repos/asf/carbondata/blob/f781337e/processing/src/main/java/org/apache/carbondata/processing/model/CarbonLoadModel.java
----------------------------------------------------------------------
diff --git a/processing/src/main/java/org/apache/carbondata/processing/model/CarbonLoadModel.java b/processing/src/main/java/org/apache/carbondata/processing/model/CarbonLoadModel.java
index ca9bb47..be2c8a5 100644
--- a/processing/src/main/java/org/apache/carbondata/processing/model/CarbonLoadModel.java
+++ b/processing/src/main/java/org/apache/carbondata/processing/model/CarbonLoadModel.java
@@ -41,10 +41,6 @@ public class CarbonLoadModel implements Serializable {
private CarbonDataLoadSchema carbonDataLoadSchema;
- private String[] aggTables;
-
- private String aggTableName;
-
private boolean aggLoadRequest;
private String storePath;
@@ -338,8 +334,6 @@ public class CarbonLoadModel implements Serializable {
copy.factFilePath = factFilePath + '/' + uniqueId;
copy.databaseName = databaseName;
copy.partitionId = uniqueId;
- copy.aggTables = aggTables;
- copy.aggTableName = aggTableName;
copy.aggLoadRequest = aggLoadRequest;
copy.loadMetadataDetails = loadMetadataDetails;
copy.isRetentionRequest = isRetentionRequest;
@@ -384,8 +378,6 @@ public class CarbonLoadModel implements Serializable {
copy.factFilePath = factFilePath;
copy.databaseName = databaseName;
copy.partitionId = partitionId;
- copy.aggTables = aggTables;
- copy.aggTableName = aggTableName;
copy.aggLoadRequest = aggLoadRequest;
copy.loadMetadataDetails = loadMetadataDetails;
copy.isRetentionRequest = isRetentionRequest;
@@ -436,8 +428,6 @@ public class CarbonLoadModel implements Serializable {
copyObj.factFilePath = null;
copyObj.databaseName = databaseName;
copyObj.partitionId = uniqueId;
- copyObj.aggTables = aggTables;
- copyObj.aggTableName = aggTableName;
copyObj.aggLoadRequest = aggLoadRequest;
copyObj.loadMetadataDetails = loadMetadataDetails;
copyObj.isRetentionRequest = isRetentionRequest;