[GitHub] [shardingsphere] azexcy commented on a diff in pull request #21750: Improve stop pipeline job, extract method to the upper level

[GitBox <gi...@apache.org>]

azexcy commented on code in PR #21750:
URL: https://github.com/apache/shardingsphere/pull/21750#discussion_r1005190831


##########
kernel/data-pipeline/core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/consistencycheck/ConsistencyCheckJob.java:
##########
@@ -74,12 +70,9 @@ public void stop() {
             log.info("stop consistency check job, jobId is null, ignore");
             return;
         }
-        for (PipelineTasksRunner each : getTasksRunnerMap().values()) {
+        for (PipelineTasksRunner each : getTaskRunners()) {
             each.stop();
         }
-        getTasksRunnerMap().clear();
-        String jobBarrierDisablePath = PipelineMetaDataNode.getJobBarrierDisablePath(getJobId());
-        pipelineDistributedBarrier.persistEphemeralChildrenNode(jobBarrierDisablePath, 0);
-        PipelineJobProgressPersistService.removeJobProgressPersistContext(getJobId());

Review Comment:
   Ok, I will extract `removeJobProgressPersistContext` method to parent class



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org