[jira] [Commented] (TINKERPOP-2461) Align CoreImports with GroovyTranslator

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TINKERPOP-2461?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17227592#comment-17227592 ] 

ASF GitHub Bot commented on TINKERPOP-2461:
-------------------------------------------

spmallette opened a new pull request #1354:
URL: https://github.com/apache/tinkerpop/pull/1354


   https://issues.apache.org/jira/browse/TINKERPOP-2461
   https://issues.apache.org/jira/browse/TINKERPOP-2466
   
   Two related changes can be found here. The first is an improvement to `withStrategies()` when called from scripts which allows a syntax that is more succinct better suited to groovy. The second is the alignment of `GroovyTranslator` to `CoreImports` so that the need to use full package names for certain classes is removed.
   
   All tests pass with `docker/build.sh -t -n -i`
   
   VOTE +1
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Align CoreImports with GroovyTranslator
> ---------------------------------------
>
>                 Key: TINKERPOP-2461
>                 URL: https://issues.apache.org/jira/browse/TINKERPOP-2461
>             Project: TinkerPop
>          Issue Type: Improvement
>          Components: translator
>    Affects Versions: 3.4.8
>            Reporter: Stephen Mallette
>            Assignee: Stephen Mallette
>            Priority: Major
>
> {{GroovyTranslator}} makes some arbitrary choices about including package names in its output.  A fair presumption should be that types common to Gremlin IO should not need the specificity of the package name (e.g. {{UUID}}). I think it would be smart if the {{DefaultTypeTranslator}} used {{ImportCustomizer}} instances to control which objects needed package specification and which did not. {{ImportCustomizer}} is the same interface handed to the {{GremlinGroovyScriptEngine}} and therefore seems to be the ideal vehicle to help control {{GroovyTranslator}} output.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)