You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2021/10/18 17:57:00 UTC
[GitHub] [flink] snuyanzin opened a new pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
snuyanzin opened a new pull request #17513:
URL: https://github.com/apache/flink/pull/17513
## What is the purpose of the change
The PRs makes pretty printing of arrays nested into maps .
## Brief change log
- *PrintUtils#deepToString* supporting maps
- *Correction of found misprints*
## Verifying this change
This change added tests and can be verified as follows:
There has been added *PrintUtilsTest#testNestedMapAndArraysToString* which highlights the issue and which could be used to check the fix.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (yes / **no**)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**)
- The serializers: (yes / **no** / don't know)
- The runtime per-record code paths (performance sensitive): (yes / no / **don't know**)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (yes / **no** / don't know)
- The S3 file system connector: (yes / **no** / don't know)
## Documentation
- Does this pull request introduce a new feature? (yes / **no**)
- If yes, how is the feature documented? (**not applicable** / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-946022176
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25190",
"triggerID" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee Azure: [SUCCESS](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] slinkydeveloper commented on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
slinkydeveloper commented on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-946424650
Hi! Thanks for the PR but we are already extensively reworking the `PrintUtils` class to unify the code with the casting provided by the runtime, here are the details: https://issues.apache.org/jira/browse/FLINK-21456
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin commented on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
snuyanzin commented on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-949466040
Hi, thanks for the info.
I've checked my cases on the mentioned branch and it seems ok
So i'm closing this PR
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot edited a comment on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
flinkbot edited a comment on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-946022176
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25190",
"triggerID" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee Azure: [PENDING](https://dev.azure.com/apache-flink/98463496-1af2-4620-8eab-a2ecc1a2e6fe/_build/results?buildId=25190)
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-946023939
Thanks a lot for your contribution to the Apache Flink project. I'm the @flinkbot. I help the community
to review your pull request. We will use this comment to track the progress of the review.
## Automated Checks
Last check on commit 7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee (Mon Oct 18 18:00:50 UTC 2021)
**Warnings:**
* No documentation files were touched! Remember to keep the Flink docs up to date!
* **This pull request references an unassigned [Jira ticket](https://issues.apache.org/jira/browse/FLINK-24579).** According to the [code contribution guide](https://flink.apache.org/contributing/contribute-code.html), tickets need to be assigned before starting with the implementation work.
<sub>Mention the bot in a comment to re-run the automated checks.</sub>
## Review Progress
* ❓ 1. The [description] looks good.
* ❓ 2. There is [consensus] that the contribution should go into to Flink.
* ❓ 3. Needs [attention] from.
* ❓ 4. The change fits into the overall [architecture].
* ❓ 5. Overall code [quality] is good.
Please see the [Pull Request Review Guide](https://flink.apache.org/contributing/reviewing-prs.html) for a full explanation of the review process.<details>
The Bot is tracking the review progress through labels. Labels are applied according to the order of the review items. For consensus, approval by a Flink committer of PMC member is required <summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot approve description` to approve one or more aspects (aspects: `description`, `consensus`, `architecture` and `quality`)
- `@flinkbot approve all` to approve all aspects
- `@flinkbot approve-until architecture` to approve everything until `architecture`
- `@flinkbot attention @username1 [@username2 ..]` to require somebody's attention
- `@flinkbot disapprove architecture` to remove an approval you gave earlier
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] flinkbot commented on pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
flinkbot commented on pull request #17513:
URL: https://github.com/apache/flink/pull/17513#issuecomment-946022176
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 7ed6fd32b50df2743eb82c9fcc7a0edefc8c11ee UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink] snuyanzin closed pull request #17513: [FLINK-24579][table-api][sql-client] Support toString for arrays as c…
Posted by GitBox <gi...@apache.org>.
snuyanzin closed pull request #17513:
URL: https://github.com/apache/flink/pull/17513
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org