[GitHub] [druid] jihoonson commented on a change in pull request #12025: fix issues with multi-value string constant expressions

[GitBox <gi...@apache.org>]

jihoonson commented on a change in pull request #12025:
URL: https://github.com/apache/druid/pull/12025#discussion_r764436410



##########
File path: processing/src/main/java/org/apache/druid/segment/virtual/ExpressionSelectors.java
##########
@@ -201,6 +201,9 @@ public static DimensionSelector makeDimensionSelector(
 
     if (baseSelector instanceof ConstantExprEvalSelector) {
       // Optimization for dimension selectors on constants.
+      if (plan.is(ExpressionPlan.Trait.NON_SCALAR_OUTPUT)) {
+        return DimensionSelector.multiConstant(Arrays.asList(baseSelector.getObject().asStringArray()), extractionFn);

Review comment:
       Should it pass null instead of a singleton list of null when `baseSelector.getObject().asStringArray()` is null?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org