You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by alsorokin <gi...@git.apache.org> on 2015/08/13 14:08:41 UTC
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
GitHub user alsorokin opened a pull request:
https://github.com/apache/cordova-windows/pull/114
CB-8936 Windows logs: Improvements
https://issues.apache.org/jira/browse/CB-8936
- Now also showing WWATerminateApplication
- Script now exits if no channels can be enabled
- Log cleanup (hide line and column fields if they are both 0)
- Slight code refactoring
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MSOpenTech/cordova-windows CB-8936
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-windows/pull/114.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #114
----
commit ffcb0f928ff14551b378f08069fdc9d0d0b10b5a
Author: alsorokin <al...@akvelon.com>
Date: 2015-08-13T12:05:25Z
CB-8936 Windows logs: Improvements
- Now also showing WWATerminateApplication
- Script now exits if no channels can be enabled
- Log cleanup (hide line and column fields if they are both 0)
- Slight code refactoring
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/114#issuecomment-131469577
These logs are global and hence, we should filter to the application ID for the current app. I believe we should already have logic to parse the application ID.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/114#issuecomment-131192964
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-windows/pull/114
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-windows/pull/114#discussion_r37140530
--- Diff: template/cordova/lib/log.js ---
@@ -114,32 +132,47 @@ function parseEvents(output) {
var results = [];
events.forEach(function (event) {
- // Get only unhandled exceptions from Admin log
- if (getElementValue(event, './System/Channel') === 'Microsoft-Windows-AppHost/Admin' &&
- typeof getElementValue(event, './UserData/WWAUnhandledApplicationException') === 'undefined') {
+ // Get only informative logs
+ if ((getElementValue(event, './System/Channel') === 'Microsoft-Windows-AppHost/Admin') &&
+ (typeof getElementValue(event, './UserData/WWAUnhandledApplicationException') === 'undefined') &&
+ (typeof getElementValue(event, './UserData/WWATerminateApplication') === 'undefined')) {
+ return;
+ }
+ if ((getElementValue(event, './System/Channel') === 'Microsoft-Windows-AppHost/ApplicationTracing') &&
+ (typeof getElementValue(event, './UserData/WWADevToolBarLog') === 'undefined')) {
return;
}
var result = {
- channel: getElementValue(event, './System/Channel'),
- timeCreated: getElementValue(event, './System/TimeCreated', 'SystemTime'),
- pid: getElementValue(event, './System/Execution', 'ProcessID'),
- proc: getElementValue(event, './UserData/WWADevToolBarLog/DisplayName'),
- source: getElementValue(event, './UserData/WWADevToolBarLog/Source'),
- documentFile: getElementValue(event, './UserData/WWADevToolBarLog/DocumentFile') ||
- getElementValue(event, './UserData/WWAUnhandledApplicationException/DocumentFile'),
- line: getElementValue(event, './UserData/WWADevToolBarLog/Line'),
- column: getElementValue(event, './UserData/WWADevToolBarLog/Column'),
- sourceFile: getElementValue(event, './UserData/WWAUnhandledApplicationException/SourceFile'),
- sourceLine: getElementValue(event, './UserData/WWAUnhandledApplicationException/SourceLine'),
- sourceColumn: getElementValue(event, './UserData/WWAUnhandledApplicationException/SourceColumn'),
- message: getElementValue(event, './UserData/WWADevToolBarLog/Message'),
- displayName: getElementValue(event, './UserData/WWAUnhandledApplicationException/DisplayName'),
- appName: getElementValue(event, './UserData/WWAUnhandledApplicationException/ApplicationName'),
- errorType: getElementValue(event, './UserData/WWAUnhandledApplicationException/ErrorType'),
- errorDescription: getElementValue(event, './UserData/WWAUnhandledApplicationException/ErrorDescription'),
- stackTrace: getElementValue(event, './UserData/WWAUnhandledApplicationException/StackTrace'),
+ channel: getElementValue(event, './System/Channel'),
+ timeCreated: getElementValue(event, './System/TimeCreated', 'SystemTime'),
+ pid: getElementValue(event, './System/Execution', 'ProcessID'),
+ proc: getElementValue(event, './UserData/WWADevToolBarLog/DisplayName'),
--- End diff --
Nit: instead of proc & 'Process' - we should call it 'App Name'
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-windows pull request: CB-8936 Windows logs: Improvements
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on the pull request:
https://github.com/apache/cordova-windows/pull/114#issuecomment-131469603
When I press Ctrl+C I ran into an issue - the node process got a busy hang with pegged CPU and the last log line was - 'Disabling channel Microsoft-Windows-AppHost/ApplicationTracing'. Is the synchronous shelljs.exec causing problem when the process is terminating?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org