You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by pengjianhua <pe...@zte.com.cn> on 2017/09/19 02:15:05 UTC
Review Request 62398: "Select/Deselect All" should along with the
chosed permission
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62398/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Bugs: RANGER-1790
https://issues.apache.org/jira/browse/RANGER-1790
Repository: ranger
Description
-------
"Select/Deselect All" should along with the chosed permission .
For example ,in hbase_dev
1?when choose all permissions,"Select All" should be auto chosed .
2?when remove all permissions,"Deselect All" should be auto removed.
Diffs
-----
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0803945e
Diff: https://reviews.apache.org/r/62398/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 62398: From the ease of use point of view,
Select / Deselect All and other checkbox should be associated in add/edit
permissions pop window.
Posted by Qiang Zhang <zh...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62398/#review186236
-----------------------------------------------------------
Ship it!
Ship It!
- Qiang Zhang
On 九月 21, 2017, 8:47 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62398/
> -----------------------------------------------------------
>
> (Updated 九月 21, 2017, 8:47 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1790
> https://issues.apache.org/jira/browse/RANGER-1790
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The current logic is as following:
> 1. Other checkbox will be selected when the "Select checkbox" was selected.
> 2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
> 3. The "Select / Deselect All" checkbox was not automatically selected when all checkbox were Selected.
> 4. The "Select / Deselect All" checkbox was not automatically deselected when all checkbox were deselected.
> The right logic should be as following:
> 1. Other checkbox will be selected when the "Select checkbox" was selected.
> 2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
> 3. The "Select / Deselect All" checkbox was automatically selected when all checkbox were Selected.
> 4. The "Select / Deselect All" checkbox was automatically deselected when all checkbox were deselected.
> Please refer to select-all-permissions.png and select-all-permissions-01.png.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0803945e
>
>
> Diff: https://reviews.apache.org/r/62398/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 62398: From the ease of use point of view,
Select / Deselect All and other checkbox should be associated in add/edit
permissions pop window.
Posted by Alejandro Fernandez <af...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62398/#review186292
-----------------------------------------------------------
Ship it!
Ship It!
- Alejandro Fernandez
On Sept. 21, 2017, 8:47 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62398/
> -----------------------------------------------------------
>
> (Updated Sept. 21, 2017, 8:47 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1790
> https://issues.apache.org/jira/browse/RANGER-1790
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The current logic is as following:
> 1. Other checkbox will be selected when the "Select checkbox" was selected.
> 2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
> 3. The "Select / Deselect All" checkbox was not automatically selected when all checkbox were Selected.
> 4. The "Select / Deselect All" checkbox was not automatically deselected when all checkbox were deselected.
> The right logic should be as following:
> 1. Other checkbox will be selected when the "Select checkbox" was selected.
> 2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
> 3. The "Select / Deselect All" checkbox was automatically selected when all checkbox were Selected.
> 4. The "Select / Deselect All" checkbox was automatically deselected when all checkbox were deselected.
> Please refer to select-all-permissions.png and select-all-permissions-01.png.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0803945e
>
>
> Diff: https://reviews.apache.org/r/62398/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>
Re: Review Request 62398: From the ease of use point of view,
Select / Deselect All and other checkbox should be associated in add/edit
permissions pop window.
Posted by pengjianhua <pe...@zte.com.cn>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62398/
-----------------------------------------------------------
(Updated 九月 21, 2017, 8:47 a.m.)
Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
Summary (updated)
-----------------
From the ease of use point of view, Select / Deselect All and other checkbox should be associated in add/edit permissions pop window.
Bugs: RANGER-1790
https://issues.apache.org/jira/browse/RANGER-1790
Repository: ranger
Description (updated)
-------
The current logic is as following:
1. Other checkbox will be selected when the "Select checkbox" was selected.
2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
3. The "Select / Deselect All" checkbox was not automatically selected when all checkbox were Selected.
4. The "Select / Deselect All" checkbox was not automatically deselected when all checkbox were deselected.
The right logic should be as following:
1. Other checkbox will be selected when the "Select checkbox" was selected.
2. Other checkbox will be deselected when the "Deselect checkbox" was selected.
3. The "Select / Deselect All" checkbox was automatically selected when all checkbox were Selected.
4. The "Select / Deselect All" checkbox was automatically deselected when all checkbox were deselected.
Please refer to select-all-permissions.png and select-all-permissions-01.png.
Diffs
-----
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0803945e
Diff: https://reviews.apache.org/r/62398/diff/1/
Testing
-------
Thanks,
pengjianhua
Re: Review Request 62398: "Select/Deselect All" should along with the
chosed permission
Posted by Colm O hEigeartaigh <co...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62398/#review185797
-----------------------------------------------------------
It's not clear from the description above what the problem is, can you update the description with more information please?
- Colm O hEigeartaigh
On Sept. 19, 2017, 2:15 a.m., pengjianhua wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62398/
> -----------------------------------------------------------
>
> (Updated Sept. 19, 2017, 2:15 a.m.)
>
>
> Review request for ranger, Alok Lal, Ankita Sinha, Don Bosco Durai, Colm O hEigeartaigh, Gautam Borad, Madhan Neethiraj, Ramesh Mani, Selvamohan Neethiraj, Velmurugan Periasamy, and Qiang Zhang.
>
>
> Bugs: RANGER-1790
> https://issues.apache.org/jira/browse/RANGER-1790
>
>
> Repository: ranger
>
>
> Description
> -------
>
> "Select/Deselect All" should along with the chosed permission .
> For example ,in hbase_dev
> 1?when choose all permissions,"Select All" should be auto chosed .
> 2?when remove all permissions,"Deselect All" should be auto removed.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js 0803945e
>
>
> Diff: https://reviews.apache.org/r/62398/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> pengjianhua
>
>