You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/23 16:03:03 UTC

[GitHub] [calcite] michaelmior commented on a change in pull request #1272: [CALCITE-3130]Implement JSON_UNQUOTE, JSON_QUOTE function

michaelmior commented on a change in pull request #1272: [CALCITE-3130]Implement JSON_UNQUOTE, JSON_QUOTE function
URL: https://github.com/apache/calcite/pull/1272#discussion_r306403692
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/DataContext.java
 ##########
 @@ -122,7 +122,13 @@
      *
      * <p>Default value is "user.name" from
      * {@link System#getProperty(String)}. */
-    SYSTEM_USER("systemUser", String.class);
+    SYSTEM_USER("systemUser", String.class),
+
+    /** The sql mode.
+     *
+     * <p>Default value is "" from
+     * {@link System#getProperty(String)}. */
+    SQL_MODE("sqlMode", String.class);
 
 Review comment:
   SQL mode appears to be a MySQL-specific thing. Could you explain why it's needed here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services