[GitHub] [incubator-superset] rusackas commented on a change in pull request #12060: feat: View all fav charts and dashboards

[GitBox <gi...@apache.org>]

rusackas commented on a change in pull request #12060:
URL: https://github.com/apache/incubator-superset/pull/12060#discussion_r544021021



##########
File path: superset-frontend/src/components/ListView/types.ts
##########
@@ -55,11 +55,14 @@ type FilterOperator =
   | 'all_text'
   | 'chart_all_text'
   | 'dataset_is_null_or_empty'
-  | 'between';
+  | 'between'
+  | 'dashboard_is_fav'
+  | 'chart_is_fav';

Review comment:
       Does anyone feel particularly passionate about changing the frontend AND backend over this, or can we let it slide for now?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org