You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "anmolxlight (via GitHub)" <gi...@apache.org> on 2026/05/22 12:46:40 UTC
[PR] fix(scheduler): ignore queued stale success after defer [airflow]
anmolxlight opened a new pull request, #67330:
URL: https://github.com/apache/airflow/pull/67330
## Summary
- Extend the resume-after-defer stale executor success handling to cover `TaskInstanceState.QUEUED` in addition to `SCHEDULED`.
- Parametrize the scheduler regression test so both scheduled and queued post-trigger states avoid the external-kill mismatch path when `next_method` is set.
## Testing
- `uv run --project airflow-core pytest airflow-core/tests/unit/jobs/test_scheduler_job.py::TestSchedulerJob::test_process_executor_events_stale_success_when_rescheduled_after_defer -q --with-db-init`
- `uv run prek run ruff --files airflow-core/src/airflow/jobs/scheduler_job_runner.py airflow-core/tests/unit/jobs/test_scheduler_job.py`
- `uv run prek run ruff-format --files airflow-core/src/airflow/jobs/scheduler_job_runner.py airflow-core/tests/unit/jobs/test_scheduler_job.py`
Closes #67287
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(scheduler): ignore queued stale success after defer [airflow]
Posted by "anmolxlight (via GitHub)" <gi...@apache.org>.
anmolxlight commented on PR #67330:
URL: https://github.com/apache/airflow/pull/67330#issuecomment-4900390787
Closing — fix already landed in #68741.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(scheduler): ignore queued stale success after defer [airflow]
Posted by "anmolxlight (via GitHub)" <gi...@apache.org>.
anmolxlight commented on PR #67330:
URL: https://github.com/apache/airflow/pull/67330#issuecomment-4900390376
Thanks @steveahnahn for catching that — confirmed that #68741 already addressed this. Closing this PR as superseded. 👋
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(scheduler): ignore queued stale success after defer [airflow]
Posted by "anmolxlight (via GitHub)" <gi...@apache.org>.
anmolxlight closed pull request #67330: fix(scheduler): ignore queued stale success after defer
URL: https://github.com/apache/airflow/pull/67330
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] fix(scheduler): ignore queued stale success after defer [airflow]
Posted by "steveahnahn (via GitHub)" <gi...@apache.org>.
steveahnahn commented on PR #67330:
URL: https://github.com/apache/airflow/pull/67330#issuecomment-4898145098
Hey @anmolxlight, looks like the diagnosis is right and this exact fix already landed in #68741 (merged Jul 2), which also closed #67287. That PR makes the same change to the `ti_requeued` resume-after-defer guard in `process_executor_events` It accepts `ti.state in (TaskInstanceState.SCHEDULED, TaskInstanceState.QUEUED)` instead of `TaskInstanceState.SCHEDULED` only, and adds a dedicated regression test for the queued variant.
I believe this PR can be closed now!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org