[GitHub] [incubator-superset] kgabryje commented on a change in pull request #11412: fix: multiple issues with FilterPopover

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #11412:
URL: https://github.com/apache/incubator-superset/pull/11412#discussion_r512073218



##########
File path: superset-frontend/src/explore/components/AdhocFilterOption.jsx
##########
@@ -60,7 +60,6 @@ class AdhocFilterOption extends React.PureComponent {
     // isNew is used to indicate whether to automatically open the overlay
     // once the overlay has been opened, the metric/filter will never be
     // considered new again.
-    this.props.adhocFilter.isNew = false;

Review comment:
       As I wrote in https://github.com/apache/incubator-superset/pull/11428, although mutating a prop certainly isn't ok, it might not be that simple to fix it. I encountered many problems with auto-opening popup when I tried to copy your solution or to make a new state variable. I think replacing that ugly line requires a more serious refactor




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org