You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues-all@impala.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2022/10/11 20:35:00 UTC

[jira] [Commented] (IMPALA-11492) ExprTest.Utf8MaskTest fails when en_US.UTF-8 is not present

    [ https://issues.apache.org/jira/browse/IMPALA-11492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17616071#comment-17616071 ] 

ASF subversion and git services commented on IMPALA-11492:
----------------------------------------------------------

Commit 11e66523d6070957f84c1fdbba3e26ecf3888d74 in impala's branch refs/heads/master from Joe McDonnell
[ https://gitbox.apache.org/repos/asf?p=impala.git;h=11e66523d ]

IMPALA-11526: Install en_US.UTF-8 locale into docker images

In IMPALA-11492, ExprTest.Utf8MaskTest was failing on some
configurations because the en_US.UTF-8 was missing. Since the
Docker images don't contain en_US.UTF-8, they are subject
to the same bug. This was confirmed by adding tests cases
to the test_utf8_strings.py end-to-end test and running it
in the dockerized tests.

This add the appropriate language pack to the list of packages
installed for the Docker build.

Testing:
 - This adds end-to-end tests to test_utf8_strings.py covering the
   same cases that were failing in ExprTest.Utf8MaskTest. They
   failed without the added languages packs, and now succeed.

Change-Id: I353f257b3cb6d45f7d0a28f7d5319fdb457e6e3d
Reviewed-on: http://gerrit.cloudera.org:8080/19080
Tested-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Laszlo Gaal <la...@cloudera.com>


> ExprTest.Utf8MaskTest fails when en_US.UTF-8 is not present
> -----------------------------------------------------------
>
>                 Key: IMPALA-11492
>                 URL: https://issues.apache.org/jira/browse/IMPALA-11492
>             Project: IMPALA
>          Issue Type: Bug
>          Components: Backend
>    Affects Versions: Impala 4.2.0
>            Reporter: Joe McDonnell
>            Assignee: Joe McDonnell
>            Priority: Critical
>             Fix For: Impala 4.2.0, Impala 4.1.1
>
>
> In the docker-based tests on Redhat 8 / Ubuntu 20, the ExprTest.Utf8MaskTest fails:
> {noformat}
> /home/impdev/Impala/be/src/exprs/expr-test.cc:369
> Value of: GetValue(expr, ColumnType(TYPE_STRING))
>   Actual: "xxxx \xC3\xA1\xC3\xA4\xC3\xA8\xC3\xBC XXXX \xC3\x81\xC3\x84\xC3\x88\xC3\x9C"
> Expected: expected_result
> Which is: "xxxx xxxx XXXX XXXX"
> mask('abcd  ABCD '){noformat}
> These come with the C.UTF-8 locale installed. This error goes away if I change bin/bootstrap_system.sh to install langpacks-us (Centos) or language-pack-en (Ubuntu), which installs the en_US.UTF-8 locale.
> This might be related to this code: [https://github.com/apache/impala/blob/master/be/src/exprs/mask-functions-ir.cc#L150]
> Installing the language packs is easy, but I'm not sure if users would have those installed.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-all-unsubscribe@impala.apache.org
For additional commands, e-mail: issues-all-help@impala.apache.org