You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "dongYES (GitHub)" <gi...@apache.org> on 2019/02/01 05:57:24 UTC
[GitHub] [incubator-dubbo] dongYES opened pull request #3414: code
style
## What is the purpose of the change
XXXXX
## Brief changelog
XXXXX
## Verifying this change
XXXXX
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/incubator-dubbo/issues) field for the change (usually before you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/incubator-dubbo/tree/master/dubbo-test).
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure unit-test and integration-test pass.
- [ ] If this contribution is large, please follow the [Software Donation Guide](https://github.com/apache/incubator-dubbo/wiki/Software-donation-guide).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3414: code
style
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
same question as @satansk raised.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] codecov-io commented on issue #3414: code
style
Posted by "codecov-io (GitHub)" <gi...@apache.org>.
# [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=h1) Report
> Merging [#3414](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=desc) into [2.6.x](https://codecov.io/gh/apache/incubator-dubbo/commit/19f30941f2b14c7df1a989b9c115c75c5667cdd9?src=pr&el=desc) will **decrease** coverage by `0.06%`.
> The diff coverage is `17.5%`.
[](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## 2.6.x #3414 +/- ##
============================================
- Coverage 47.28% 47.21% -0.07%
+ Complexity 4300 4294 -6
============================================
Files 554 554
Lines 24412 24416 +4
Branches 4321 4322 +1
============================================
- Hits 11544 11529 -15
- Misses 11077 11087 +10
- Partials 1791 1800 +9
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...o/common/extension/support/ActivateComparator.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vY29tbW9uL2V4dGVuc2lvbi9zdXBwb3J0L0FjdGl2YXRlQ29tcGFyYXRvci5qYXZh) | `17.5% <17.5%> (+6.38%)` | `3 <3> (ø)` | :arrow_down: |
| [...bo/rpc/cluster/support/FailbackClusterInvoker.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9jbHVzdGVyL3N1cHBvcnQvRmFpbGJhY2tDbHVzdGVySW52b2tlci5qYXZh) | `73.68% <0%> (-13.16%)` | `7% <0%> (-1%)` | |
| [...ba/dubbo/remoting/transport/netty/NettyClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbmV0dHkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9yZW1vdGluZy90cmFuc3BvcnQvbmV0dHkvTmV0dHlDbGllbnQuamF2YQ==) | `74.13% <0%> (-8.63%)` | `12% <0%> (-1%)` | |
| [...om/alibaba/dubbo/rpc/filter/ActiveLimitFilter.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9ycGMvZmlsdGVyL0FjdGl2ZUxpbWl0RmlsdGVyLmphdmE=) | `77.77% <0%> (-5.56%)` | `5% <0%> (-1%)` | |
| [...rpc/protocol/dubbo/telnet/InvokeTelnetHandler.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1kdWJiby9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JwYy9wcm90b2NvbC9kdWJiby90ZWxuZXQvSW52b2tlVGVsbmV0SGFuZGxlci5qYXZh) | `54.21% <0%> (-3.62%)` | `13% <0%> (-2%)` | |
| [...ba/dubbo/registry/multicast/MulticastRegistry.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tcmVnaXN0cnkvZHViYm8tcmVnaXN0cnktbXVsdGljYXN0L3NyYy9tYWluL2phdmEvY29tL2FsaWJhYmEvZHViYm8vcmVnaXN0cnkvbXVsdGljYXN0L011bHRpY2FzdFJlZ2lzdHJ5LmphdmE=) | `47.28% <0%> (-1.68%)` | `29% <0%> (ø)` | |
| [...baba/dubbo/remoting/transport/mina/MinaClient.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tcmVtb3RpbmcvZHViYm8tcmVtb3RpbmctbWluYS9zcmMvbWFpbi9qYXZhL2NvbS9hbGliYWJhL2R1YmJvL3JlbW90aW5nL3RyYW5zcG9ydC9taW5hL01pbmFDbGllbnQuamF2YQ==) | `57.81% <0%> (-1.57%)` | `8% <0%> (-1%)` | |
| [.../com/alibaba/dubbo/monitor/dubbo/DubboMonitor.java](https://codecov.io/gh/apache/incubator-dubbo/pull/3414/diff?src=pr&el=tree#diff-ZHViYm8tbW9uaXRvci9kdWJiby1tb25pdG9yLWRlZmF1bHQvc3JjL21haW4vamF2YS9jb20vYWxpYmFiYS9kdWJiby9tb25pdG9yL2R1YmJvL0R1YmJvTW9uaXRvci5qYXZh) | `89.71% <0%> (+1.86%)` | `15% <0%> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=footer). Last update [19f3094...b4cbb90](https://codecov.io/gh/apache/incubator-dubbo/pull/3414?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 closed pull request #3414: code
style
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
[ pull request closed by beiwei30 ]
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] satansk commented on issue #3414: code
style
Posted by "satansk (GitHub)" <gi...@apache.org>.
It's same to https://github.com/apache/incubator-dubbo/pull/3412 ?
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org
[GitHub] [incubator-dubbo] beiwei30 commented on issue #3414: code
style
Posted by "beiwei30 (GitHub)" <gi...@apache.org>.
looks like it's a dup, close it now.
[ Full content available at: https://github.com/apache/incubator-dubbo/pull/3414 ]
This message was relayed via gitbox.apache.org for notifications@dubbo.apache.org