[GitHub] vlsi commented on a change in pull request #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds

[GitBox <gi...@apache.org>]

vlsi commented on a change in pull request #1034: [CALCITE-2819] Add version of LoptOptimizeJoinRule that uses the first ordering it finds
URL: https://github.com/apache/calcite/pull/1034#discussion_r260946766
 
 

 ##########
 File path: core/src/test/java/org/apache/calcite/test/RelOptRulesTest.java
 ##########
 @@ -4292,6 +4293,20 @@ private Sql checkSubQuery(String sql) {
     checkPlanning(program, sql);
   }
 
+  @Test public void testConvertMultiJoinRuleLoptOptimizeJoinRuleNonOptimized() throws Exception {
 
 Review comment:
   Does this really validate that the rule was executed only once?
   It does not look so. At least from the brief analysis of the test code.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services