You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2018/10/25 16:58:27 UTC
[GitHub] merlimat commented on a change in pull request #2845: Make proxy
advertise protocol version of client to broker
merlimat commented on a change in pull request #2845: Make proxy advertise protocol version of client to broker
URL: https://github.com/apache/pulsar/pull/2845#discussion_r228254899
##########
File path: pulsar-proxy/src/main/java/org/apache/pulsar/proxy/server/DirectProxyHandler.java
##########
@@ -218,7 +223,7 @@ protected void handleConnected(CommandConnected connected) {
state = BackendState.HandshakeCompleted;
- inboundChannel.writeAndFlush(Commands.newConnected(connected.getProtocolVersion())).addListener(future -> {
+ inboundChannel.writeAndFlush(Commands.newConnected(protocolVersion)).addListener(future -> {
Review comment:
I think this might not be correct. The intent here is to tell the client the protocol version supported by broker. By sending `protocolVersion` we send back the client's version
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services