You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/10/12 10:17:31 UTC

[GitHub] [flink] zentol commented on pull request #20757: [FLINK-27919] Add FLIP-27-based source for data generation (FLIP-238)

zentol commented on PR #20757:
URL: https://github.com/apache/flink/pull/20757#issuecomment-1275931140

   I would deprecated it now so we have some incentive to migrate existing usages (in particular internal!) to migrate to the new source.
   
   > the actual generators seem to all default to no-op [DataGenerator.java#L45](https://github.com/apache/flink/blob/c6997c97c575d334679915c328792b8a3067cfb5/flink-streaming-java/src/main/java/org/apache/flink/streaming/api/functions/source/datagen/DataGenerator.java#L45), so it should be no issue to use the generator function instead
   
   Looks like the DataGenTableSource _may_ use the stateful `SequenceGenerator` (`DataGenTableSourceFactory#createContainer`)?.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org