[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6801: enable Reproducible Builds

[GitBox <gi...@apache.org>]

DaanHoogland commented on code in PR #6801:
URL: https://github.com/apache/cloudstack/pull/6801#discussion_r1045822771


##########
tools/checkstyle/pom.xml:
##########
@@ -25,12 +25,18 @@
     <version>4.18.0.0-SNAPSHOT</version>
 
     <properties>
+        <project.build.outputTimestamp>10</project.build.outputTimestamp>
         <project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
         <project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
     </properties>
 
     <build>
         <plugins>
+            <plugin>
+                <groupId>org.apache.maven.plugins</groupId>
+                <artifactId>maven-jar-plugin</artifactId>
+                <version>3.2.2</version>

Review Comment:
   it is used nowhere else, hence @hboutemy put it in the local pom.xml. I think it is alright in this case.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org