You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/27 12:34:47 UTC
[GitHub] [netbeans] neilcsmith-net opened a new pull request, #4286: Alter FlatLaf tab colouring to address visibility.
neilcsmith-net opened a new pull request, #4286:
URL: https://github.com/apache/netbeans/pull/4286
Experiment inspired by discussion in #3115 to see if concerns can be addressed (mostly) by colour changes rather than changing away from the existing flat design.
Improve colour contrast between tabs and background.
Move accent colour (underline) to top of tabs.
Make view tabs active / selected behaviour same as editor tabs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address focus visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1172604543
I did a build with this patch and https://github.com/apache/netbeans/pull/4298. Before/after screenshots on my Windows 11 laptop at 150% DPI scaling:
I'm fine with merging this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169056417
OK, squashed and updated. Will leave CI to do its thing. I'll merge in a couple of days if no-one gets there first.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net merged pull request #4286: Alter FlatLaf tab colouring to address focus visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net merged PR #4286:
URL: https://github.com/apache/netbeans/pull/4286
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169771164
OK, tried reverting to a darker tab background on FlatLaf dark. Getting adequate contrast with Eirik's request to use `@background` for selected tab means we have to go quite dark (original image used `@componentBackground`). Still, I think it is probably better this way around.
Also changed hover colours to be (or derive from) `@componentBackground` so they don't merge. Dark laf goes lighter on hover too, which is more like the menu than the previous tab design.
Also checked with various alternative `@accentBaseColor` settings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169482867
i was using this with the dark theme a few hours, here some observations:
- the contrast of inactive tabs (text vs background) is a bit low which makes it more difficult to read compared to NB 14, intuitively this looks as if it would be a disabled component which can't be interacted with
- inactive tab mousevoer renders with the same color as the components around it which looks as if the tab is gone just the text remains, i prefer the version of NB 14 there too
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170468841
@mbien I agree that this is a problem. Again, @neilcsmith-net it would be solved by making the split pane handles the same background color as the tab background. That's how it's done in both the Windows and the Aqua LAFs:
<img width="1306" alt="backgroundsame" src="https://user-images.githubusercontent.com/886243/176539351-9810f558-8179-49c3-8c45-5dd5eb5a842c.png">
Neil's objection was: "So having the dividers the same colour as the toolbar and status bar makes sense unless we add yet another colour." I don't understand this objection; it would be the same color as is used in the tab area?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r908756388
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatViewTabDisplayerUI.java:
##########
@@ -232,7 +232,9 @@ private void paintTabBackgroundAtScale1x(Graphics2D g, int index, int width, int
g.fillRect(0, height - contentBorderWidth, width, contentBorderWidth);
}
- if (showTabSeparators && index >= 0) {
+ if (showTabSeparators && index >= 0 &&
+ ((!isSelected(index) && !isSelected(index + 1)
+ || selectedBackground.equals(activeBackground)))) {
Review Comment:
Underlying code supports out of range values.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1167565262
Thanks for taking a look @eirikbakke I had already tried 1&3, but have revised.
1. The problem is that either the editor tabs don't match the toolbar or the view tabs don't match their contents (or we have editor tab and view tabs different colours). Have matched with toolbar and moved the colours around a bit for more contrast. Couldn't make dark tab background dark enough so made it lighter instead, which I think looks a bit better anyway?
2. Sorry, I think this is really important for showing focus, and I deliberately gave it a little more contrast. Fed up of typing in the wrong tab! :wink:
3. I tried without entirely already and didn't like it. Went to try again and accidentally used the background colour - think this works quite well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1167673101
Thanks for the latest tweaks!
1) The solution is to make the editor tab and the toolbar tab different colors; this is what I did in https://github.com/apache/netbeans/pull/3115 . Having the tab color match the background below is one of the most important visual cues for an active tab.
2) I suspect that fixing (3) will solve the problem you describe here. Are you describing a split-window situation where you have two different rows of editor tabs?
3) The problem with having a grey bar is that the unfocused tab looks too much like a focused tab, leading to the problem you described in (2). In peripheral vision, there is no color vision, and so grey and blue looks identical. I think only the focused tab should have a bar on top. You could also make it a brighter and more saturated blue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1168908797
I think this is strictly an improvement upon the status quo, so I'll say go ahead and merge once the index check is added if needed.
I'll probably go back to https://github.com/apache/netbeans/pull/3115 and split out some smaller, uncontroversial PRs, to add the various configuration properties that were necessary to support bordered tabs (even if we don't use them in the default theme).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169050098
@neilcsmith-net Initially I just want to make sure that all the different variations can be supported by setting keys in FlatLAF.properties, e.g. by adding the properties needed to support borders. Making it easier to override FlatLAF.properties (without having to compile anything) might be good, though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r911223525
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java:
##########
@@ -219,11 +222,17 @@ private void paintInteriorAtScale1x(Graphics2D g, Component c, int width, int he
if (selected && underlineHeight > 0) {
// paint underline if tab is selected
int underlineHeight = (int) Math.round(FlatEditorTabCellRenderer.underlineHeight * scale);
- g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
- if (underlineAtTop)
+ if (underlineAtTop) {
+ g.setColor(contentBorderColor);
+ int borderWidth = (int) (1 * scale);
+ g.fillRect(0, 0, borderWidth, height);
+ g.fillRect(width - tabSeparatorWidth - borderWidth, 0, borderWidth, height);
+ g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
g.fillRect(0, 0, width - tabSeparatorWidth, underlineHeight);
Review Comment:
OK, as long as we agree that this code might be adjusted in the future.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1168498574
Moved inactive underline colour back to what it was in first image (and close to original colour). Kept tab background same as toolbar.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169682328
Thanks @DevCharly @mbien Agreed! I'll have another look now. I swapped to lighter because I was running out of value (HSV) space to contrast, but I agree keeping it darker would be better.
Was intending to look at consistency with multitabs separately.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169884095
shouldn't the sub tabs also look the same as the parent tabs?
<img width="216" alt="image" src="https://user-images.githubusercontent.com/795658/176429277-c2b73270-918e-44db-b0b5-67c38fae4577.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1167725504
1. That presumes that all view tabs have that different background, which they don't. That's an issue to consider elsewhere IMO. Reduce the inconsistency further, not add to it!
2. I'm talking about editor and view (eg. terminal) tabs. I don't find the bar by itself (no matter how bright we make it) enough of a focus hint. I want to keep the background colour follows focus behaviour.
3. Yes, I agree, which is why it's _effectively_ removed. Making it the background colour makes the tab slightly shallower than the container, with the bar effectively appearing on top. I don't see the second set of images makes the unfocused tab look focused in the same way the first set did. At the same time, I find current FlatLaf very difficult to see what the active tab is in an unfocused set.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1167426695
This is good! A few proposed adjustments:
1) Could you make the active editor tab the same color as the editor toolbar? (Either by adjusting the tab color or the toolbar color or both.)
2) Can we have the tab background be the same in the sidebar and the editor area? I.e. get rid of the special background color for the "active" area. We already know which tab area is active by seeing which tab is active (and it's usually always the editor area anyway).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address focus visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1172160952
Squashed everything again. Ready to merge when green from my perspective.
@eirikbakke thanks. The main reason it came up here at all was the need originally to hide the content borders to make overline and contiguous tab content work. Given other issues that raised and lack of consensus on how to fix, reverting to existing borders and limiting this PR solely to the tab regions (inc. minimal fixes to render correctly) made more sense. I also changed my mind working with it - things sometimes seem right in a static screenshot, but not in use.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170493327
A better mockup summarizing my proposed improvements...
![Uploading MoreMockup.png…]()
But if you prefer I can open my own PR later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r911204305
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java:
##########
@@ -219,11 +222,17 @@ private void paintInteriorAtScale1x(Graphics2D g, Component c, int width, int he
if (selected && underlineHeight > 0) {
// paint underline if tab is selected
int underlineHeight = (int) Math.round(FlatEditorTabCellRenderer.underlineHeight * scale);
- g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
- if (underlineAtTop)
+ if (underlineAtTop) {
+ g.setColor(contentBorderColor);
+ int borderWidth = (int) (1 * scale);
+ g.fillRect(0, 0, borderWidth, height);
+ g.fillRect(width - tabSeparatorWidth - borderWidth, 0, borderWidth, height);
+ g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
g.fillRect(0, 0, width - tabSeparatorWidth, underlineHeight);
Review Comment:
What is this code doing? It seems it's trying to draw side borders if underlineAtTop is true. That seems to be a bit ad hoc, and should probably be in a separate configuration property.
Changes here are going to start conflicting with the changes in https://github.com/apache/netbeans/pull/3115 , which I'm still hoping to integrate later. Perhaps we could keep this PR limited to simple changes to FlatLAF.properties, as was originally intended? I can help make these improvements later...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1168448894
1. Yes, you can see this in your screenshot with the `Output` region. I don't think adding _another_ level of inconsistency with multiple tab colours is the right approach. In some ways, I'd prefer the tab colour to be as my first image - it fixes the other problem you raise!
2. Not many other options while not losing the current focus utility that FlatLaf has.
3. There isn't a border, there's padding. If we wanted one, we could make it the same as the tab separator colour. I'm not against borders - I have an issue with adding gradients to a flat look and feel. If you look at the examples you shared from other software, a border alone (unless it's the accent colour) is not enough. Border or not, they work because of contrasting inactive tab background. @Chris2011 made that point too.
4. I think it should be clear where the window regions are. So having the dividers the same colour as the toolbar and status bar makes sense unless we add yet another colour. FlatLaf already has this blurring problem. But if you want the active tab to be the toolbar colour (rather than current default), it's going to blend into those. Maybe we should tweak to draw the tab separator line at the start as well?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170159721
> Getting adequate contrast with Eirik's request to use @background for selected tab means we have to go quite dark (original image used @componentBackground). Still, I think it is probably better this way around.
Yes, I think this is good!
> Or now too close to editor background?
That's fine; the editor background is not adjacent to the tab background.
As commented in-code, you can also drop the separator line after the last tab:
<img width="353" alt="seplast" src="https://user-images.githubusercontent.com/886243/176480270-6364b2c9-7d27-4ceb-a674-bf5b3bea9e14.png">
> Moved inactive underline colour back to what it was in first image
Wait, why did this grey line on top of the active-but-unfocused tab pop back in? See my earlier comment about blue and grey being indistinguishable in peripheral vision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170421465
is it intended that the tab content has no border? Empty tabs next to each other look like they are the same component (see usages + project tab). (If you dock them next to each other its even more visible)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171127835
@eirikbakke not sure whether those thick borders look good. Especially the vertical ones.
Would be nicer to have thin borders/dividers.
Maybe we should consider extending `MultiSplitPane` to support thin dividers,
where only 1px is visible, but the user still has a 6px wide invisible drag area:
Some years ago I wrote an article on how to do this with `JSplitPane`:
https://www.formdev.com/blog/swing-tip-jsplitpane-with-zero-size-divider/
Then it could look like this (red arrows mark thin dividers):
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169928441
Yeah, tabs in tabs are also a pattern that I don't like and hard to achieve from a design perspective. Just wanted to ask, thx for the clarification :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] mbien commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169222424
as general note:
if a PR is updated and travis didn't run yet, please cancel the old runs here:
https://app.travis-ci.com/github/apache/netbeans/pull_requests
(gh actions are configured to do this automatically)
i just did this for this PR since travis is in slow mode again and a lot was in queue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170696592
> Aqua has different colour for view tabs background and split pane handles here though, which is what I was on about.
Oh yeah, now I understand. That is indeed unnecessary!
> This would also be helped by integrating your border fix, which would allow option of bringing borders back.
OK, will experiment in a later PR after this one is merged.
> Still disagree on removing unfocused line, particularly with FlatLaf update allowing inner tabs to sync on focus.
OK, as long as it's an intentional choice.
> Also not sure about changing the line colour unless you're proposing changing the accent colour?
I guess, yes. It was just an opportunity to make the focus indication a little brighter. Not too important though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171764272
@eirikbakke honestly, no. Having tried it in its full context, I don't like the bleed of the tab background colour. And with the content borders going back to how they were it's not needed to differentiate regions either.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171831634
Alright, you can leave it at whichever overall solution you find most harmonious. If we end up making thin draggable sliders later, it will require some of these things to be redesigned in any case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] Chris2011 commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
Chris2011 commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1168641213
I like it, just to be a little croaker, this looks a bit broken. I would prefer to not see the right line due to the editor tabs also not shows it.
<img width="844" alt="image" src="https://user-images.githubusercontent.com/795658/176175350-b48a9685-12c7-4bdf-8208-fc84e1a9ad5d.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1168719290
@Chris2011 thanks. Should be fixed, and work like before if a different selected background colour not set. Please try.
> pretty interesting that this all is done just by editing properties. Like CSS in a HashMap.
@mbien yes, there's a wealth of stuff that can be styled by properties in a CSS fashion, as well as useful style functions - see https://www.formdev.com/flatlaf/properties-files/ Next steps might be - open some of that up so users can easily configure / create themes, and possibly look at the additional properties that are available for tabs upstream that our displayers don't support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r908644471
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatViewTabDisplayerUI.java:
##########
@@ -232,7 +232,9 @@ private void paintTabBackgroundAtScale1x(Graphics2D g, int index, int width, int
g.fillRect(0, height - contentBorderWidth, width, contentBorderWidth);
}
- if (showTabSeparators && index >= 0) {
+ if (showTabSeparators && index >= 0 &&
+ ((!isSelected(index) && !isSelected(index + 1)
+ || selectedBackground.equals(activeBackground)))) {
Review Comment:
Good change. Do you need an index check, e.g. !(index < getDataModel().size() && isSelected(index + 1))?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1167748430
1) OK, one way or another, there will be some inconsistency here; some TopComponents will have toolbars and others will not.
2) OK, I see the utility. It just looks bad with all of these different background colors.
3) If you think the line is necessary, then consider: Should we not just have borders around the active tab, like in normal tab components? I'm not convinced that removing all borders is actually a good thing for the UI. Completely "flat" may be too minimal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169923453
@Chris2011 IMO, no. The idea is to make the primary window tabs / regions stand out - making sub tabs similar would make it more cluttered and harder to see. However, I would like to see if we can make the tab highlight colour follow which region is focused - ie. should also be light grey here. But we already have that problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169015404
Thanks @eirikbakke Options for border and sizing would be really good. There's also a bunch of other configuration options in upstream [FlatTabbedPaneUI](https://github.com/JFormDesigner/FlatLaf/blob/f8c769644d4594ae330d543ce7588e917d658232/flatlaf-core/src/main/java/com/formdev/flatlaf/ui/FlatTabbedPaneUI.java#L107-L165) that might be worth considering?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r908784195
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatViewTabDisplayerUI.java:
##########
@@ -232,7 +232,9 @@ private void paintTabBackgroundAtScale1x(Graphics2D g, int index, int width, int
g.fillRect(0, height - contentBorderWidth, width, contentBorderWidth);
}
- if (showTabSeparators && index >= 0) {
+ if (showTabSeparators && index >= 0 &&
+ ((!isSelected(index) && !isSelected(index + 1)
+ || selectedBackground.equals(activeBackground)))) {
Review Comment:
That's not really documented in the API; better to be explicit. Also, wouldn't you want to omit the separator after the last tab? (This is not what was previously done, but I think it would be an improvement.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] DevCharly commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
DevCharly commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1169314841
BTW please also test the Multi-Tabs implementation (see PR #1865).
The keys in the properties files start with `nb.multitabs.`.
Multi-Tabs do not yet support `nb.multitabs.underlineAtTop=true`, but this should be easy to add to `org.netbeans.core.multitabs.impl.TabDataRenderer`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1170530835
@eirikbakke yes, think you're right on the split pane handles. Sorry, wrong call! Aqua has different colour for view tabs background and split pane handles here though, which is what I was on about.
This would also be helped by integrating your border fix, which would allow option of bringing borders back.
Also agree on right tab separator.
Still disagree on removing unfocused line, particularly with FlatLaf update allowing inner tabs to sync on focus.
Also not sure about changing the line colour unless you're proposing changing the accent colour?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171229094
Having now tried it, I agree with @DevCharly - the thick border appears too much. Pending a change like the above, I've reverted the border colours back to how they originally were, and added a fix to remove the extra top border from editor tab tabs. I've also added side borders when "underline" is at top. If border colours are set to `@background` will still show as earlier images.
Added code to remove last separator (which for editor tabs is from @eirikbakke ), and lowered the contrast of the unfocused tab underline a little, too.
Possibly final images (again) :laughing: -
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on code in PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#discussion_r911214196
##########
platform/o.n.swing.laf.flatlaf/src/org/netbeans/swing/laf/flatlaf/ui/FlatEditorTabCellRenderer.java:
##########
@@ -219,11 +222,17 @@ private void paintInteriorAtScale1x(Graphics2D g, Component c, int width, int he
if (selected && underlineHeight > 0) {
// paint underline if tab is selected
int underlineHeight = (int) Math.round(FlatEditorTabCellRenderer.underlineHeight * scale);
- g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
- if (underlineAtTop)
+ if (underlineAtTop) {
+ g.setColor(contentBorderColor);
+ int borderWidth = (int) (1 * scale);
+ g.fillRect(0, 0, borderWidth, height);
+ g.fillRect(width - tabSeparatorWidth - borderWidth, 0, borderWidth, height);
+ g.setColor(ren.isActive() ? underlineColor : inactiveUnderlineColor);
g.fillRect(0, 0, width - tabSeparatorWidth, underlineHeight);
Review Comment:
I reverted the border colour change, and it looks odd without this. The "underline" sits on the content border now either way. I think it's needed for consistency, and I'd like this to work standalone if merged. You can enhance or remove as needed then, but this is a more sensible default IMO.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] eirikbakke commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
eirikbakke commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171416547
If we're going to start drawing borders around tabs, then we'll need the improvements from https://github.com/apache/netbeans/pull/3115/ , to introduce configuration properties from these and to make sure the borders line up on HiDPI screens and so on. Perhaps this PR could be limited to things that can be improved with changes in FlatLAF.properties only, or changes compatible with https://github.com/apache/netbeans/pull/3115/ ? This will be a big help when I later try to integrate the work from the latter.
The latest screenshots once again has the problem of the split pane area not having the same background as the inactive tab background. Mocked-up fix:
> Maybe we should consider extending MultiSplitPane to support thin dividers, where only 1px is visible, but the user still has a 6px wide invisible drag area:
Yes, this could be a good improvement! If we did this, we could also get rid of the 4px border at the edge of the screens (which would fix e.g. the Fitt's law issue described at https://github.com/ultorg/public_issues/issues/11 ). But that would be for a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #4286: Alter FlatLaf tab colouring to address visibility.
Posted by GitBox <gi...@apache.org>.
neilcsmith-net commented on PR #4286:
URL: https://github.com/apache/netbeans/pull/4286#issuecomment-1171438862
As I said, split pane colour not changed but border put back based on @DevCharly comment which I agree with having tried it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists