You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datalab.apache.org by yt...@apache.org on 2021/03/16 15:39:04 UTC

[incubator-datalab] branch DATALAB-2330 created (now 2d24a48)

This is an automated email from the ASF dual-hosted git repository.

ytykhun pushed a change to branch DATALAB-2330
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git.


      at 2d24a48  [DATALAB-2330] removed extra vertical scrollbar during account adding

This branch includes the following new commits:

     new 2d24a48  [DATALAB-2330] removed extra vertical scrollbar during account adding

The 1 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org


[incubator-datalab] 01/01: [DATALAB-2330] removed extra vertical scrollbar during account adding

Posted by yt...@apache.org.
This is an automated email from the ASF dual-hosted git repository.

ytykhun pushed a commit to branch DATALAB-2330
in repository https://gitbox.apache.org/repos/asf/incubator-datalab.git

commit 2d24a4869d9202f232f604125b708d35d6c9eaa9
Author: Yurii Tykhun <ty...@gmail.com>
AuthorDate: Tue Mar 16 17:35:14 2021 +0200

    [DATALAB-2330] removed extra vertical scrollbar during account adding
---
 .../src/app/resources/manage-ungit/manage-ungit.component.html   | 4 ++--
 .../src/app/resources/manage-ungit/manage-ungit.component.scss   | 9 ++++++---
 2 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.html b/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.html
index 439a2dc..2f690fa 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.html
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.html
@@ -29,7 +29,7 @@
           <i class="material-icons">people_outline</i>Add account
         </button>
         <mat-divider></mat-divider>
-        <mat-list *ngIf="gitCredentials?.length">
+        <mat-list *ngIf="gitCredentials?.length" [ngStyle]="editableForm && gitCredentials?.length && {'height': '250px'}">
           <mat-list-item class="list-header">
             <div class="hostname-field">Host name</div>
             <div class="user-field">User</div>
@@ -38,7 +38,7 @@
             <div class="actions"></div>
           </mat-list-item>
 
-          <div class="scrollingList" id="scrolling">
+          <div class="scrollingList" id="scrolling" [ngStyle]="editableForm && gitCredentials?.length && {'height': '200px'}">
             <mat-list-item *ngFor="let item of gitCredentials">
               <div class="hostname-field ellipsis">
                 <strong>{{ item.hostname }}</strong>
diff --git a/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.scss b/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.scss
index a31be76..920df46 100644
--- a/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.scss
+++ b/services/self-service/src/main/resources/webapp/src/app/resources/manage-ungit/manage-ungit.component.scss
@@ -30,7 +30,7 @@
   .scrollingList {
     overflow-x: hidden;
     padding: 5px 0;
-    height: 185px;
+    height: 250px;
 
     &.info {
       display: flex;
@@ -125,7 +125,10 @@
     margin-top: 60px;
   }
 
-  .mat-list-item{
-    color: #607d8b;
+  .mat-list {
+    height: 300px;
+    .mat-list-item{
+      color: #607d8b;
+    }
   }
 }


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datalab.apache.org
For additional commands, e-mail: commits-help@datalab.apache.org