[GitHub] [doris] yinzhijian commented on a diff in pull request #10415: [feature](nereids) Support analyze for test SSB

[GitBox <gi...@apache.org>]

yinzhijian commented on code in PR #10415:
URL: https://github.com/apache/doris/pull/10415#discussion_r910724625


##########
fe/fe-core/src/main/java/org/apache/doris/nereids/trees/expressions/ExpressionConverter.java:
##########
@@ -134,16 +130,16 @@ public Expr visitLiteral(Literal literal, PlanTranslatorContext context) {
 
     // TODO: Supports for `distinct`
     @Override
-    public Expr visitFunctionCall(FunctionCall function, PlanTranslatorContext context) {
+    public Expr visitBoundFunction(BoundFunction function, PlanTranslatorContext context) {
         List<Expr> paramList = new ArrayList<>();
-        for (Expression expr : function.getFnParams().getExpressionList()) {
+        for (Expression expr : function.getArguments()) {
             paramList.add(visit(expr, context));

Review Comment:
   DefaultExpressionVisitor.visit always returns null
   ```suggestion
               paramList.add(expr.accept(this, context));
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org